PCBnew: opacity slider upside down

[simon]

scenario:

Double click on a colored square in front of a layer name in the layer manager. in the color picker, on the right, the opacity slider is upside down. 100% is at the bottom, and on further inspection the HVS slider as well. see attached picture.

kicad version:

Application: kicad
Version: 5.1.0-060a0da~80~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.0g zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-47-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.3.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Michael Kavanagh (michaelkavanagh)]

@simon, did you forget to attach the picture?

[Michael Kavanagh (michaelkavanagh)]

Nevermind, easy enough fix.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 1ccef6dc802dc999b98660c68d840a96b4dbf618
https://git.launchpad.net/kicad/patch/?id=1ccef6dc802dc999b98660c68d840a96b4dbf618

[John Beard (john-j-beard)]

@Michael thanks for the patch: I have committed your patch to both branches.

I split it up into a "prelude" for handling wxFormBuilder's automatic changes and then the actual change. This keeps the history much tidier (otherwise it's tricky to see what's changed under all wxFB's internal format churn). You can do this by opening the wxFB project, then saving and generating the .cpp file, then committing just that change, then making your changes on top.

Also, you can add the "fixes" alias to git to put the fixes tag in to allow the KiCad janitor to link it to this issue: http://docs.kicad-pcb.org/doxygen/commit_messages.html#commit_fixes_alias

[John Beard (john-j-beard)]

Whoops, I see you *did* tag the bug correctly, I must have lost it in the split-up! Sorry!

[simon (p-info-1)]

GRMBH. I completely forgot to attach the image. Sorry for that.

For documentation's sake i will do it now

[KiCad Janitor (kicad-janitor)]

Fixed in revision 1ccef6dc802dc999b98660c68d840a96b4dbf618
https://git.launchpad.net/kicad/patch/?id=1ccef6dc802dc999b98660c68d840a96b4dbf618