charm does not cleanup after the relation is removed/departed

[Syed Mohammad Adnan Karim]

The charm doesn't remove itself as the cloud-provider from snaps after the relation is removed/departed.
For example:

Before running $ juju remove-relation openstack-integrator kubernetes-master:
$ sudo snap get kube-controller-manager
Key Value
cert-dir <nil>
client-ca-file /root/cdk/custom-ca/okca.crt
cloud-config /var/snap/kube-controller-manager/common/cloud-config.conf
cloud-provider openstack
logtostderr true
master http://127.0.0.1:8080
min-resync-period 3m
root-ca-file /root/cdk/ca.crt
service-account-private-key-file /root/cdk/serviceaccount.key
tls-cert-file /root/cdk/server.crt
tls-private-key-file /root/cdk/server.key
v 2

After running $ juju remove-relation openstack-integrator kubernetes-master:
$ sudo snap get kube-controller-manager
Key Value
cert-dir <nil>
client-ca-file /root/cdk/custom-ca/okca.crt
cloud-config /var/snap/kube-controller-manager/common/cloud-config.conf
cloud-provider openstack
logtostderr true
master http://127.0.0.1:8080
min-resync-period 3m
root-ca-file /root/cdk/ca.crt
service-account-private-key-file /root/cdk/serviceaccount.key
tls-cert-file /root/cdk/server.crt
tls-private-key-file /root/cdk/server.key
v 2

As you can see, the cloud-provider value remained as openstack. The snap's cloud-provider value had to be manually cleared with $ sudo snap set kube-controller-manager cloud-provider="". It's also possible that the charm doesn't cleanup elsewhere.

[Mike Wilson (knobby)]

https://github.com/charmed-kubernetes/charm-kubernetes-worker/pull/6
https://github.com/charmed-kubernetes/charm-kubernetes-master/pull/14

[Mike Wilson (knobby)]

This fix is avaiable in revision 523 of kubernetes-worker charm and revision 661 of kubernetes-master charm.