The Angular datepicker in the fmeditor does not go into read-only mode

[Jane Sandberg]

Steps to recreate: create an fmeditor with a timestamp field listed as read-only

<eg-fm-record-editor #editDialog
  idlClass="bresv"
  readonlyFields="cancel_time"
</eg-fm-record-editor>

Note that the resulting fmeditor displays the datepicker and lets the user change the date just fine.

The date-select component has an input called "disabled", but none called readOnly. Perhaps the readOnly version could use the disabled version of this widget?

[Bill Erickson (berick)]

My plan is to give the date-select widget a readOnly mode so the value may be displayed as a string instead of a disabled selector, both for consistency and since strings are easier to read.

[Bill Erickson (berick)]

Changes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1822414-ang-date-select-disable

It includes two commits, including sandbox example.

The first commit was extracted from the working branch for bug #1821382 (formatValuePipe), so that code will need some rebasing once this is merged.

[Jane Sandberg (sandbergja)]

Looks great, Bill. Thanks for this! Signed off and rebased branch here: user/sandbergja/lp1822414-ang-date-select-disable

[Galen Charlton (gmc)]

I've pushed this to master after rebasing, correcting the authorship of the rebased patches, and adding a follow-up. Thanks, Bill and Jane!

I have not pushed this to rel_3_3 yet, as we have a decision to make first: whether or not to backport the bug 1831780 changes to rel_3_3. If we do, the patches for this bug that I pushed to master can be cherry-picked; if we don't, we can use the ones from Jane's signoff branch (after correcting authorship) but that will mark the beginning of a permanent divergence for data-select between rel_3_3 and master.

[Jane Sandberg (sandbergja)]

Thanks for catching my authorship error, Galen. Taking credit for Bill's work!

I don't think there are a ton of readonly timestamp fields in the 3.3 interfaces, so I think it's okay not to backport.