Footprint Browser should use same grid style as Footprint Editor

Bug #1822401 reported by Hildo Guillardi Júnior
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Wishlist
Michael Kavanagh

Bug Description

Footprint library browser should use the same Pcbnew grid configuration on canvas.

Application: kicad
Version: 5.1.0-unknown-a7270f8~82~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.15.0-46-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Hildo Guillardi Júnior (hildogjr) wrote :
summary: - Footprint library browser should use same Pcbnew grid
+ Footprint library browser should use same grid style as Pcbnew
Changed in kicad:
importance: Undecided → Wishlist
status: New → Triaged
tags: added: pcbnew
Revision history for this message
Wayne Stambaugh (stambaughw) wrote : Re: Footprint library browser should use same grid style as Pcbnew

The only way I would allow this is if it was an option. I prefer to be able to use a different grid in the footprint editor and I suspect that I am not alone in that preference.

Changed in kicad:
status: Triaged → Opinion
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

I think this refers to the "grid options" and "grid style", i.e. the dots/lines/crosses etc. (under Display Options in Pcbnew preferences). I can't find any way of setting this for the footprint viewer.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Michael, those setting are in the footprint editor preferences dialog.

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

@Wayne, the Footprint Editor Display Options do not affect the Footprint Library Browser (i.e. FOOTPRINT_VIEWER_FRAME). At least I can't get it to.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

Duh! I misread the report. In the absence of independent settings, the footprint viewer should probably inherit the board editor settings. I would prefer that the viewer have it's own settings but I don't have a really strong opinion one way or another.

Changed in kicad:
status: Opinion → Triaged
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

The Symbol Library Browser inherits its grid display settings from the Symbol Library Editor, so it would make sense to replicate this behaviour for the Footprint Library Browser/Editor.

Since this is inconsistent I would consider bumping the importance up from "Wishlist" to "Low".

Revision history for this message
Hildo Guillardi Júnior (hildogjr) wrote :

Yes.
Checking now, the symbol editor have the same behaviour, displaying V-H lines instead dots as Eeschema.

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :
Changed in kicad:
milestone: none → 5.1.1
Revision history for this message
Seth Hillbrand (sethh) wrote :

Looks good. Thanks Michael!

Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a611269975d98d28c4d43e39d5b92eaa4444c180
https://git.launchpad.net/kicad/patch/?id=a611269975d98d28c4d43e39d5b92eaa4444c180

Changed in kicad:
status: Triaged → Fix Committed
assignee: nobody → Michael Kavanagh (michaelkavanagh)
Revision history for this message
Hildo Guillardi Júnior (hildogjr) wrote :

Should I create a report issue for Symbol editor?

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

@Hildo, the behaviour already existed in the symbol editor/viewer so no need.

Revision history for this message
Hildo Guillardi Júnior (hildogjr) wrote :

No in my Nightly

Application: kicad
Version: 5.1.0-unknown-a7270f8~82~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.15.0-46-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

Your screenshot shows the Symbol Editor and Eeschema. These have separate grid display options settable in the Preferences dialog.

The Symbol Viewer inherits its grid display options from the Symbol Editor, not Eeschema.

summary: - Footprint library browser should use same grid style as Pcbnew
+ Footprint Browser should use same grid style as Footprint Editor
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.