MARC batch edit iframe can fail to load

[Galen Charlton]

The MARC Batch Edit Dojo UI can fail to load when embedded in the AngularJS staff client if the hostname of the Evergreen server starts with "eg".

Evergreen 3.1+ (most likely)

[Galen Charlton (gmc)]

Specifically, the following line in Open-ILS/web/js/ui/default/staff/cat/catalog/app.js is at fault:

  $scope.batchedit_url = $location.absUrl().replace(/\/eg.*/, '/opac/extras/merge_template');

A URL like https://eg.example.org/eg/staff/... will match that regex starting with the hostname.

[Meg Stroup (mstroup)]

Side note (for this bug and others): an AngularJS tag would be helpful.

[Martha Driscoll (mjdriscoll)]

We ran into this on our training system which we call "egtraining". My fix to the regex is to make sure "eg" is followed by a slash. I'm not sure if this will break under other circumstances:

$scope.batchedit_url = $location.absUrl().replace(/\/eg\/.*/, '/opac/extras/merge_template');

app.js has a few more places where absUrl() may match a hostname if it has "staff" in it:

var url = $location.absUrl().replace(/\/staff.*/, '/opac/advanced');
$scope.verifyurls_url = $location.absUrl().replace(/\/staff.*/, '/url_verify/sessions');
$scope.manageauthorities_url = $location.absUrl().replace(/\/staff.*/, '/cat/authority/list');

[Jason Boyer (jboyer)]

Marking a duplicate of generic "We're regex-ing wrong" bug 1862834