status-set called on every kubeconfig write

Bug #1822021 reported by Mike Wilson
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Kubernetes Control Plane Charm
Fix Released
Low
Peter Jose De Sousa

Bug Description

unit-kubernetes-master-0: 20:49:38 INFO unit.kubernetes-master/0.juju-log Invoking reactive handler: reactive/kubernetes_master.py:795:send_data
unit-kubernetes-master-0: 20:49:38 INFO unit.kubernetes-master/0.juju-log Invoking reactive handler: reactive/kubernetes_master.py:1006:create_self_config
unit-kubernetes-master-0: 20:49:38 INFO unit.kubernetes-master/0.juju-log status-set: maintenance: Writing kubeconfig file.
...
unit-kubernetes-master-0: 20:54:32 INFO unit.kubernetes-master/0.juju-log Invoking reactive handler: reactive/kubernetes_master.py:1006:create_self_config
unit-kubernetes-master-0: 20:54:32 INFO unit.kubernetes-master/0.juju-log status-set: maintenance: Writing kubeconfig file.
...
unit-kubernetes-master-0: 21:00:10 INFO unit.kubernetes-master/0.juju-log Invoking reactive handler: reactive/kubernetes_master.py:1006:create_self_config
unit-kubernetes-master-0: 21:00:10 INFO unit.kubernetes-master/0.juju-log status-set: maintenance: Writing kubeconfig file.

Changed in charm-kubernetes-master:
status: New → Triaged
importance: Undecided → Low
milestone: none → 1.14
Changed in charm-kubernetes-master:
assignee: nobody → Peter De Sousa (pjds)
Changed in charm-kubernetes-master:
status: Triaged → In Progress
Revision history for this message
Peter Jose De Sousa (pjds) wrote :
Changed in charm-kubernetes-master:
status: In Progress → Fix Committed
Changed in charm-kubernetes-master:
status: Fix Committed → In Progress
status: In Progress → Fix Committed
Changed in charm-kubernetes-master:
status: Fix Committed → In Progress
Changed in charm-kubernetes-master:
milestone: 1.14 → none
Changed in charm-kubernetes-master:
status: In Progress → Fix Committed
summary: - kubeconfig file is written out every single hook run
+ status-set called on every kubeconfig write
Changed in charm-kubernetes-master:
milestone: none → 1.15+ck1
summary: - status-set called on every kubeconfig write
+ kubeconfig file is written out every single hook run
Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

The original impl had to be partially reverting because we missed a few things in data_changed that kept us from writing an accurate kubeconfig:

https://github.com/charmed-kubernetes/charm-kubernetes-master/pull/41

The scope of this fix is now limited to replacing the expensive status_set with debug log message.

summary: - kubeconfig file is written out every single hook run
+ status-set called on every kubeconfig write
Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

Follow-up bug to address the unnecessary writes:

https://bugs.launchpad.net/charm-kubernetes-master/+bug/1837930

Revision history for this message
George Kraft (cynerva) wrote :
Changed in charm-kubernetes-master:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.