Mistral

WorkflowExecution only has "root_execution_id" to reference a root execution

Bug #1821860 reported by Renat Akhmerov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
Medium
Renat Akhmerov
Mistral stein-rc1

Bug Description

Fetching a root execution by making a direct DB query using "root_execution_id" field is slower than using a mapped entity that can be cached in the SQLAlchemy session.

Renat Akhmerov (rakhmerov)
Changed in mistral:
milestone: none → stein-rc1
assignee: nobody → Renat Akhmerov (rakhmerov)
importance: Undecided → Medium
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.openstack.org/648021

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/648023

Revision history for this message
Renat Akhmerov (rakhmerov) wrote :

The patch to master: https://review.openstack.org/#/c/643847/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/rocky)

Reviewed: https://review.openstack.org/648023
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=77a6831224f1695c882d4289b55a187f862b0869
Submitter: Zuul
Branch: stable/rocky

commit 77a6831224f1695c882d4289b55a187f862b0869
Author: Renat Akhmerov <email address hidden>
Date: Mon Mar 18 10:41:59 2019 +0700

    Add "root_execution" mapped property to WorkflowExecution model

    * We need to avoid using direct DB queries w/o using a mapped
      model where possible for performance sake. Using a mapped entity
      property is always more efficient because it's cached in an
      SQLAlchemy session.

    Closes-Bug: #1821860

    Change-Id: I2d7652ea0cff8f2db7259d285ac98c582bf15b62
    (cherry picked from commit 32c96b1b6c340c10a12d6f598268198083681031)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (stable/stein)

Reviewed: https://review.openstack.org/648021
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=4c9e35f182ffba329a9b17cc645f2abe6d3f5606
Submitter: Zuul
Branch: stable/stein

commit 4c9e35f182ffba329a9b17cc645f2abe6d3f5606
Author: Renat Akhmerov <email address hidden>
Date: Mon Mar 18 10:41:59 2019 +0700

    Add "root_execution" mapped property to WorkflowExecution model

    * We need to avoid using direct DB queries w/o using a mapped
      model where possible for performance sake. Using a mapped entity
      property is always more efficient because it's cached in an
      SQLAlchemy session.

    Closes-Bug: #1821860

    Change-Id: I2d7652ea0cff8f2db7259d285ac98c582bf15b62
    (cherry picked from commit 32c96b1b6c340c10a12d6f598268198083681031)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 8.0.0.0rc2

This issue was fixed in the openstack/mistral 8.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 7.1.0

This issue was fixed in the openstack/mistral 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.