target names with ':' fail

Bug #182161 reported by Bryce Harrington
4
Affects Status Importance Assigned to Milestone
Moblin Image Creator
Fix Released
Low
Praj

Bug Description

After creating a new Project today, I attempted to create a Target named 'moblin box: mboard2', which failed issuing that makes me think it got confused by the ':'. The target name input box should include a check for allowed/disallowed characters and issue an error if incorrect characters are used.

Setting up initramfs-tools (0.85eubuntu20) ...

Completed 'apt-get install' successfully
tar: box\:: Not found in archive
tar: mboard2/fs: Not found in archive
tar: Error exit delayed from previous errors
ERROR: Unable to rootstrap /usr/share/pdk/platforms/menlow/target-rootstrap.tar.bz2 from moblin box: mboard2!
Traceback (most recent call last):
  File "/usr/share/pdk/lib/gui.py", line 294, in on_new_target_add_clicked
    self.current_project().create_target(target_name)
  File "/usr/share/pdk/lib/Project.py", line 356, in create_target
    raise ValueError(" ".join(output))
ValueError: tar: box\:: Not found in archive tar: mboard2/fs: Not found in archive tar: Error exit delayed from previous errors
Traceback (most recent call last):
  File "/usr/sbin/image-creator", line 64, in main
    gui.App().run()
  File "/usr/share/pdk/lib/gui.py", line 112, in run
    gtk.main()
KeyboardInterrupt
Error: Unable to run the GUI, maybe you are in a text console
Do -h for help

Revision history for this message
John L. Villalovos (happycamp) wrote :

Good catch. We will see if we can figure out a nice way to fix this.

Changed in moblin-image-creator:
assignee: nobody → prajwal-linux
Changed in moblin-image-creator:
assignee: prajwal-linux → happycamp
status: New → Triaged
Revision history for this message
John L. Villalovos (happycamp) wrote :

I have fixed this in the latest version on moblin.org, we will only allow alphanumeric characters for target names.

Changed in moblin-image-creator:
status: Triaged → Fix Committed
Jing Wang (jing-j-wang)
Changed in moblin-image-creator:
importance: Undecided → Low
milestone: none → m9
status: Fix Committed → New
Jing Wang (jing-j-wang)
Changed in moblin-image-creator:
status: New → Fix Committed
Revision history for this message
Steve Magoun (smagoun) wrote :

Target names aren't checked when you create a target with the "Add a Target" button inside the "New Project" dialog.

Changed in moblin-image-creator:
status: Fix Committed → Confirmed
Revision history for this message
Steve Magoun (smagoun) wrote :

Target names aren't checked when you create a target via the command line, either.

Changed in moblin-image-creator:
assignee: happycamp → prajwal-linux
Revision history for this message
John L. Villalovos (happycamp) wrote :

Prajwal,

Can you fix the other cases of this and then close out this bug?

Thanks,
John

Praj (prajwal-linux)
Changed in moblin-image-creator:
status: Confirmed → Fix Committed
Revision history for this message
dandan.hong@intel.com (dandan-hong) wrote :

Verify this bugs in MIC V0.45.

Changed in moblin-image-creator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.