puppet-sensu update breaks puppet-tripleo

[Cédric Jeanneret]

Hello,

We're apparently using puppet-sensu Master code. An update to the code of this module makes it break our puppet-tripleo runs with the following error:

2019-03-25 13:20:54.070921 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Class[Sensu]: parameter 'ssl_ca_source' expects a String value, got Undef at /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/profile/base/monitoring/sensu.pp:29:3 on node centos-7-rax-ord-0004233462

A quick check to the code base of puppet-sensu shows this patch:
https://github.com/sensu/sensu-puppet/commit/c907aa3727fe1514074bb40dbbaa3c9a743e3298

An issue has been pushed upstream:
https://github.com/sensu/sensu-puppet/issues/1098

We have 2 solutions:
- either pass "use_ssl => false" in tripleo::profile::base::monitoring::sensu
- pass existing, internal certificates in the same place

Cheers,

C.

[Ronelle Landy (rlandy)]

See error in the log linked below:

2019-03-25 13:20:54.070921 | centos-7 | Evaluation Error: Error while evaluating a Function Call, Class[Sensu]: parameter 'ssl_ca_source' expects a String value, got Undef at /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/profile/base/monitoring/sensu.pp:29:3 on node centos-7-rax-ord-0004233462

http://logs.openstack.org/77/645477/2/check/puppet-openstack-unit-4.8-centos-7/2519740/job-output.txt.gz#_2019-03-25_13_20_54_070921

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/647501

[Cédric Jeanneret (cjeanner)]

After some talks, pinning the version in Puppetfile_extras is the right thing to do. It's already done at another level anyway:
https://github.com/redhat-openstack/rdoinfo/blob/master/tags/stein-uc.yml#L877-L880

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/647583

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647501
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=23a7b058e8d9676fb6072a2d5dfc5c0b080181b4
Submitter: Zuul
Branch: master

commit 23a7b058e8d9676fb6072a2d5dfc5c0b080181b4
Author: Cédric Jeanneret <email address hidden>
Date: Mon Mar 25 16:05:44 2019 +0100

    Pin puppet-sensu module

    Newest versions of puppet-sensu don't take into account the
    serverless usage we can have with puppet ("puppet apply" vs "puppet
    client"), making CI fail the unit tests for this module.

    An upstream bug has been open:
    https://github.com/sensu/sensu-puppet/issues/1098

    The hash we're pinning is the same as in
    https://github.com/redhat-openstack/rdoinfo/blob/master/tags/stein-uc.yml#L880

    Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
    Closes-Bug: #1821591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/647583
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=368474f15939d60b8a5040c883ea167f768cdfa1
Submitter: Zuul
Branch: stable/rocky

commit 368474f15939d60b8a5040c883ea167f768cdfa1
Author: Cédric Jeanneret <email address hidden>
Date: Mon Mar 25 16:05:44 2019 +0100

    Pin puppet-sensu module

    Newest versions of puppet-sensu don't take into account the
    serverless usage we can have with puppet ("puppet apply" vs "puppet
    client"), making CI fail the unit tests for this module.

    An upstream bug has been open:
    https://github.com/sensu/sensu-puppet/issues/1098

    The hash we're pinning is the same as in
    https://github.com/redhat-openstack/rdoinfo/blob/master/tags/rocky.yml#L873

    Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
    Closes-Bug: #1821591

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/648240
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=48dbeafd224521ce9ba74a26cf9085c1deb6fc9e
Submitter: Zuul
Branch: stable/queens

commit 48dbeafd224521ce9ba74a26cf9085c1deb6fc9e
Author: Cédric Jeanneret <email address hidden>
Date: Mon Mar 25 16:05:44 2019 +0100

    Pin puppet-sensu module

    Newest versions of puppet-sensu don't take into account the
    serverless usage we can have with puppet ("puppet apply" vs "puppet
    client"), making CI fail the unit tests for this module.

    An upstream bug has been open:
    https://github.com/sensu/sensu-puppet/issues/1098

    The hash we're pinning is the same as in
    https://github.com/redhat-openstack/rdoinfo/blob/master/tags/queens.yml#L869

    Change-Id: I1784a06052909b108c862ef76fc69e57bd778987
    Closes-Bug: #1821591

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 10.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.5.0 release.