any import crash with systems having glib < 2.58.0

[John Purser]

I run Homebank 5.2.3 on Mint Linux. Recently my installation was upgraded from your PPA. After the upgrade when I try to import .ofx or .qfx files from my bank the program core dumps and exits. I have tried reinstalling as well as purging then installing from source but get the same results

I don't know if it's related but I did see the same error when reinstalling and compiling that said:
Unknown media type in type 'all/all'
Unknown media type in type 'all/allfiles'

I also had to use a different version of libofx than your instructions called for. Mint uses libofx7 now. I didn't see any other compile or install problems.

Details:
Homebank 5.2.3
/etc/linuxmint/info:
RELEASE=19
CODENAME=tara
EDITION="Cinnamon"
DESCRIPTION="Linux Mint 19 Tara"
DESKTOP=Gnome
TOOLKIT=GTK
NEW_FEATURES_URL=http://www.linuxmint.com/rel_tara_cinnamon_whatsnew.php
RELEASE_NOTES_URL=http://www.linuxmint.com/rel_tara_cinnamon.php
USER_GUIDE_URL=help:linuxmint
GRUB_TITLE=Linux Mint 19 Cinnamon

Error is repeatable on my machine.

Keystrokes:
File > Import
System File Open window > select file for import > Open
Homebank window "Select file(s)" > Next
Program crash with core dump

I expected the file to be opened and the process proceed to the "Import" stage.

[Sergio Soriano Peiró (sersope)]

Homebank also crash when trying to import a .csv file.

Homebank 5.2.3
Linux Mint 19.1

[cascagrossa (cascagrossa-cascao)]

Same error with segmentation fault, same version 5.2.3 in Kubuntu 18.04. Tested from Ubuntu repos and ppa:mdoyen/homebank, same error.
The workaround I found was uninstall 5.2.3 version and download, compile and install version 5.2.2. The 5.2.2 version works as expected, no segfault

[John Purser (jmpurser)]

I've installed Homebank version 5.2.2 and the import function worked well. I deleted /usr/bin/homebank and /usr/share/homebank prior to installing 5.2.2 but made no other changes to my system.

During sudo make install I again encountered the message:
Unknown media type in type 'all/all'
Unknown media type in type 'all/allfiles'

but the install went fine and the program (5.2.2) worked fine. I think it unlikely this is related to the file import problem.

[Maxime DOYEN (mdoyen)]

@John,
I don't have crash here under ubuntu 19.04, GTK 3.24.7.
could you launch the compiled 5.3.2 with gdb and then backtrace post the output here ?

gdb ./src/homebank
-- try import / wiat crash --
bt

thx

[John Purser (jmpurser)]

Maxime,

I'm doing something wrong with GDB and I don't know enough to figure
out what it is.

I have deleted /usr/bin/homebank and /usr/share/homebank, downloaded
the 5.2.3 source, compiled and reinstalled it. I get the same error.

When I try to follow your instructions I get the following:

jmpurser@Precision-M6600:~$ gdb ./source/homebank-5.2.3/src/
GNU gdb (Ubuntu 8.1-0ubuntu3) 8.1.0.20180409-git
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <
http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show
copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
./source/homebank-5.2.3/src/: Is a directory.
(gdb) bt
No stack.
(gdb) quit

I'm following the compile directions at:
http://homebank.free.fr/en/troubleshooting.php#linuxcompilation

Let me know if I need to activate debugging symbols or if I'm running
gdb incorrectly.

John Purser

On Tue, 2019-03-19 at 11:54 +0000, Maxime DOYEN wrote:
> @John,
> I don't have crash here under ubuntu 19.04, GTK 3.24.7.
> could you launch the compiled 5.3.2 with gdb and then backtrace post
> the output here ?
>
> gdb ./src/homebank
> -- try import / wiat crash --
> bt
>
>
> thx
>

[cascagrossa (cascagrossa-cascao)]

Maxime.

I was able to do what you asked. Result attached in "txt" file. As you can see the program running under gdb does not crashed, but freezed at the same point.
Compiled on Kubuntu 18.04.2, GTK+ 3.22.30.

[CHANEL (claude-chanel)]

same problem under MINT 19.1, Ubuntu 16.04 with or without cinnamon hombank 5.2.3 crash when import csv or QIF files

No problem with homebank 5.2.2
So i have reinstalled 5.2.2 and block release until this problem will bee solved

[Maxime DOYEN (mdoyen)]

GTK 3.22.30 means glib 2.56.1, released in april 2018
the problem comes from a call to glib which is ok under 2.60, but not on previous.

can some of you check this is the correct glib version ?

[cascagrossa (cascagrossa-cascao)]

Glib current version: 2.56.3 - Uploaded: 2018-09-26 - Latest for Ubuntu 18.04

[Maxime DOYEN (mdoyen)]

ok, it seems it is a glib bug:
https://gitlab.gnome.org/GNOME/glib/issues/1374

[Maxime DOYEN (mdoyen)]

@all thanks for your report and help here
the glib fix is into glib 2.58.0, so one solution is that you upgrade glib to that version or above

@cascagrossa : let try a bypass for this glib bug; if I understood correctly what the glib patch was:

please open the file named 'ui-assist-import.c'
go to line 1996 : data->txndata = g_array_sized_new(FALSE, TRUE, sizeof(ImpTxnData), nbacc);
add just below: g_array_set_size(data->txndata, nbacc);

then recompile and retest
if this succeed I will add this call for glib < 2.58.0

[cascagrossa (cascagrossa-cascao)]

Maxime.

Success! The patch worked, no more crashes or hangs.

I've imported the same "ofx" file that had crashed the unpatched version and it works now flawlessly.

Thank you for the attention and quick response.

[Jasper van der Neut - Stulen (neutstulen)]

The patch works with Ubuntu 18.04 and csv import.

Thanks!

[Maxime DOYEN (mdoyen)]

To unblock everyone, I have make a final fix and push it to the ppa.

This will be included into the 5.2.4 release.

[CHANEL (claude-chanel)]

All works now perfectly !
Very good job !
Thanks

[cascagrossa (cascagrossa-cascao)]

Maxime, just for your information.

Observed today that the compiled and patched 5.2.3 and the version installed from your ppa, both have an new error.
The "save button" and the "save command" at the file menu are both dimmed after any import or modification of any data.

The "save as" command at the file menu works and saves the file.

The compiled version 5.2.2 also works as expected, save button and command are functional.

[CHANEL (claude-chanel)]

I confirm, The "save button" and the "save command" at the file menu are both dimmed after any import And if i quit the application , nos save is proposed
But if i make a modification manually on any data , add or modify a category, the save Button is now active, and When i quit, it is proposed to save.
To resume :
Just Import, no save
Import and modify after import, save is possible

[Maxime DOYEN (mdoyen)]

This would mean that your import did not make any change at all.

Strange, as there was no code modification on the change counter between those 2 version.
I do not reproduce this.
Anyone else ?

[CHANEL (claude-chanel)]

After import, add operations but this is not considered as a change.
Impossible to save.
If i click on any operations imported, make no change ..but save is now possible !
This is perfectly easy to reproduce on my PC (Mint 19.1)

[Maxime DOYEN (mdoyen)]

what is the exact sequence:
- what type of file: ofx/qif/csv ?
- import to existing account, global account ?

can you reproduce with an empty file ?

[CHANEL (claude-chanel)]

Tested today ver 5.2.4
All is ok, no more problems
Thanks