Add shortcuts to AutoDJ tooltips

Bug #1820508 reported by naught101
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
ronso0

Bug Description

AutoDJ buttons have shortcuts, but the tooltips don't mention them (Deere, master).

I had a look at the code, but I couldn't figure out how shortcuts for other buttons were generated.

__________
related: lp:1702643

Tags: keyboard skin
Revision history for this message
Daniel Schürmann (daschuer) wrote :

In the skin area, the short cuts are automatically added here:
https://github.com/mixxxdj/mixxx/blob/8aeda6ff17ba7c135d6a373b3ffa6077c42f5b37/src/skin/legacyskinparser.cpp#L2192

The Auto DJ Buttons are generated differently using a *.ui file.
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/dlgautodj.ui#L52

A poor man's solution would be to statically add the default tooltip.
A Better solution would be to reuse portions of the skin code to append the tooltip depending on the keyboard setup.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
naught101 (naught101) wrote :

Ah, I ignored that legacyskinparser.cpp because I assumed that it was only for older pre-2.0 skins. Perhaps it should be renamed?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

It has already this name in Mixxx 1.11. I guess since the first attempt to switch to qml which is still on the wishlist.

Revision history for this message
ronso0 (ronso0) wrote :

As a first step I'll add all AutoDJ tooltip strings to dlgautodj.cpp and add the keyboard shortcuts there. Much like this:
https://github.com/mixxxdj/mixxx/blob/master/src/library/autodj/dlgautodj.cpp#L107

After that someone else may add the code to auto-generate tooltips from the current keyboard layout.

Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
status: Confirmed → In Progress
ronso0 (ronso0)
description: updated
Revision history for this message
ronso0 (ronso0) wrote :
ronso0 (ronso0)
Changed in mixxx:
status: In Progress → Fix Committed
milestone: none → 2.3.0
tags: added: keyboard skin
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9613

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.