Deploy fails if enable-serial-console is False

[Liam Young]

If enable-serial-console is False then the charm errors because it tries to resume a non-existent service:

2019-03-15 11:49:23 DEBUG config-changed Traceback (most recent call last):
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/hooks/config-changed", line 1101, in <module>
2019-03-15 11:49:23 DEBUG config-changed main()
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/hooks/config-changed", line 1093, in main
2019-03-15 11:49:23 DEBUG config-changed hooks.execute(sys.argv)
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/core/hookenv.py", line 914, in execute
2019-03-15 11:49:23 DEBUG config-changed self._hooks[hook_name]()
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/hooks/nova_cc_utils.py", line 1296, in wrapped_f
2019-03-15 11:49:23 DEBUG config-changed return f(*args, **kwargs)
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/contrib/openstack/utils.py", line 1546, in wrapped_f
2019-03-15 11:49:23 DEBUG config-changed stopstart, restart_functions)
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/core/host.py", line 740, in restart_on_change_helper
2019-03-15 11:49:23 DEBUG config-changed r = lambda_f()
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/contrib/openstack/utils.py", line 1545, in <lambda>
2019-03-15 11:49:23 DEBUG config-changed (lambda: f(*args, **kwargs)), __restart_map_cache['cache'],
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/contrib/hardening/harden.py", line 93, in _harden_inner2
2019-03-15 11:49:23 DEBUG config-changed return f(*args, **kwargs)
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/hooks/config-changed", line 293, in config_changed
2019-03-15 11:49:23 DEBUG config-changed ch_host.service_resume('nova-consoleauth')
2019-03-15 11:49:23 DEBUG config-changed File "/var/lib/juju/agents/unit-nova-cloud-controller-0/charm/charmhelpers/core/host.py", line 243, in service_resume
2019-03-15 11:49:23 DEBUG config-changed service_name, upstart_file, sysv_file))
2019-03-15 11:49:23 DEBUG config-changed ValueError: Unable to detect nova-consoleauth as SystemD, Upstart /etc/init/nova-consoleauth.conf or SysV /etc/init.d/nova-consoleauth
2019-03-15 11:49:23 ERROR juju.worker.uniter.operation runhook.go:129 hook "config-changed" failed: exit status 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/643587

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/643587
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=ba19f921c531906995b6b105a37c135950b06d53
Submitter: Zuul
Branch: master

commit ba19f921c531906995b6b105a37c135950b06d53
Author: Liam Young <email address hidden>
Date: Fri Mar 15 13:44:17 2019 +0000

    Check console enabled before starting console svc

    Check if console is enabled in this deploy before trying to start
    console service. As part of this add a functions to determine whether
    console is enabled and change existing methods to use them.

    Change-Id: I91e2654bb0c5f89f51c703330ae2bd0a64cc84f3
    Closes-Bug: #1820266