Umanaged volumes missing from Cinder manageable-list when using 3par FC/iscsi

[Tzach Shefi]

Description of problem: Umnaged Cinder volumes don't show up on manageable-list, when testing with 3par FC/iSCSI backend, on LVM iSCSI this works fine.

Version-Release number of selected component (if applicable):
python-cinderclient-1.9.0-6.el7ost.noarch
python-cinder-9.1.4-44.el7ost.noarch
openstack-cinder-9.1.4-44.el7ost.noarch

How reproducible:
Every time

Steps to Reproduce:
1. Configure a system with 3par FC or iSCSI backend
cinder service-list
| cinder-volume | hostgroup@3parfc | nova | enabled | up | 2019-03-13T11:39:01.000000 | - |

The backend config section:
[3parfc]
volume_backend_name = 3parfc
hpe3par_api_url = https://....:8080/api/v1
hpe3par_username = admin
hpe3par_password = .......
hpe3par_cpg = SSD_r5
san_ip = .......
san_login = admin
san_password = ......
volume_driver = cinder.volume.drivers.hpe.hpe_3par_fc.HPE3PARFCDriver
hpe3par_debug = true
hpe3par_snapshot_retention = 0
hpe3par_snapshot_expiration = 1
max_over_subscription_ratio = 20.0
reserved_percentage = 15
use_multipath_for_image_xfer = true
image_volume_cache_enabled = false

2. Create a Cinder volume
cinder create 1 --name vol1
+--------------------------------+--------------------------------------+
| Property | Value |
+--------------------------------+--------------------------------------+
| attachments | [] |
| availability_zone | nova |
| bootable | false |
| consistencygroup_id | None |
| created_at | 2019-03-13T11:41:01.000000 |
| description | None |
| encrypted | False |
| id | bb75366c-c428-4fb7-81b7-1d6c3f4caccc |
| metadata | {} |
| migration_status | None |
| multiattach | False |
| name | vol1 |
| os-vol-host-attr:host | None |
| os-vol-mig-status-attr:migstat | None |
| os-vol-mig-status-attr:name_id | None |
| os-vol-tenant-attr:tenant_id | 1fba79e9f1a54ba6bb0f49053a4e9857 |
| replication_status | disabled |
| size | 1 |
| snapshot_id | None |
| source_volid | None |
| status | creating |
| updated_at | None |
| user_id | 65a72bf00f3e4f9fa1566c027dae6f39 |
| volume_type | None |
+--------------------------------+--------------------------------------+

cinder show bb75366c-c428-4fb7-81b7-1d6c3f4caccc
+--------------------------------+--------------------------------------+
| Property | Value |
+--------------------------------+--------------------------------------+
| attachments | [] |
| availability_zone | nova |
| bootable | false |
| consistencygroup_id | None |
| created_at | 2019-03-13T11:41:01.000000 |
| description | None |
| encrypted | False |
| id | bb75366c-c428-4fb7-81b7-1d6c3f4caccc |
| metadata | {} |
| migration_status | None |
| multiattach | False |
| name | vol1 |
| os-vol-host-attr:host | hostgroup@3parfc#SSD_r5 |
| os-vol-mig-status-attr:migstat | None |
| os-vol-mig-status-attr:name_id | None |
| os-vol-tenant-attr:tenant_id | 1fba79e9f1a54ba6bb0f49053a4e9857 |
| replication_status | disabled |
| size | 1 |
| snapshot_id | None |
| source_volid | None |
| status | available |
| updated_at | 2019-03-13T11:41:03.000000 |
| user_id | 65a72bf00f3e4f9fa1566c027dae6f39 |
| volume_type | None |
+--------------------------------+--------------------------------------+

3. Even before I unmanage the ^volume, we hit an issue as I should have already seen several volumes here already, from previous umanange attempts and other systems which share this backend.

cinder manageable-list hostgroup@3parfc#SSD_r5
+-----------+------+----------------+-----------------+-----------+------------+
| reference | size | safe_to_manage | reason_not_safe | cinder_id | extra_info |
+-----------+------+----------------+-----------------+-----------+------------+
+-----------+------+----------------+-----------------+-----------+------------+

4. Now I'll unmanage the volume we created on step 2
cinder unmanage bb75366c-c428-4fb7-81b7-1d6c3f4caccc

5. Recheck manageable-list, again empty.
We should have at least gotten the volume we unmanged on step 3.

cinder manageable-list hostgroup@3parfc#SSD_r5
+-----------+------+----------------+-----------------+-----------+------------+
| reference | size | safe_to_manage | reason_not_safe | cinder_id | extra_info |
+-----------+------+----------------+-----------------+-----------+------------+
+-----------+------+----------------+-----------------+-----------+------------+

Actual results:
Manageable list returns no volumes which we can import.

Expected results:
I should get a list of unmanaged volumes on the backend that I can import/manage.
Tested this on another system same version but with LVM iSCSI and it worked fine, the unmanaged volume would shouldup on the managelable list.

Additional info: Unsure if it's either a config or 3par specific bug.

https://docs.openstack.org/cinder/rocky/configuration/block-storage/drivers/hpe-3par-driver.html

supported operation include:
Manage and unmanage a volume.
Manage and unmanage a snapshot.

[Eric Harney (eharney)]

3par hasn't implemented get_manageable_volumes() yet.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/cinder/+/850836

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/cinder/+/850836
Committed: https://opendev.org/openstack/cinder/commit/c112542cf5471641a47a94c89b9b80dfa14d701d
Submitter: "Zuul (22348)"
Branch: master

commit c112542cf5471641a47a94c89b9b80dfa14d701d
Author: raghavendrat <email address hidden>
Date: Mon Jul 25 06:59:55 2022 +0000

    HPE 3PAR: Fix umanaged volumes & snapshots missing

    The umanaged volumes & snapshots are missing when below commands
    are executed:
    cinder manageable-list
    cinder snapshot-manageable-list

    To address this, added two functions:
    get_manageable_volumes()
    get_manageable_snapshots()

    Closes-Bug: #1819903
    Change-Id: Ie178e48958a69ef2b6c329e132de2c772d5c1a40

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/cinder/+/907257

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/cinder/+/907257
Reason: stable/yoga branch of openstack/cinder is about to be deleted. To be able to do that, all open patches need to be abandoned. Please cherry pick the patch to unmaintained/yoga if you want to further work on this patch.