Search box overlaps navigaiton icons on right side of page

[Kevin Dibble]

Mahara version: Mahara 18.10.1testing
Browser: Chrome, Safari, Firefox windows edge
OS: Mac
PHP: 7.0
Database: Mysql 8

Issue:
Search box is set with a right margin of 193px, but the icons on the right take up more than that space.

Solution:
change the lines 38 and 39 in htdocs/theme/raw/layout/nav/_navbar.scss to
        right: 25%;
        margin: 0;

The 25% value is to match the layout grid to keep the right icons clear.

Patch file with the change attached (A recompile of the css is necessary to confirm the change)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/9635

[Liam (liam-sharpe)]

Hi Kevin

I dont seem to be able to replicate your issue of overlapping icons and search box on top of the latest master branch of Mahara.

I can see that your margin: 25% does line up the searchbar with the right sidebar, but we dont have this sidebar on some pages which leaves the searchbar looking out of place. Currently, the searchbar is placed with equal spacing after the icons which is its normal behaviour.

Thanks,
Liam

[Liam (liam-sharpe)]

Steps I tried:
* Chrome on Ubuntu 18.04 on latest version of master
* Chrome on Ubuntu 18.04 on latest version of master with cherry-picked patches (https://reviews.mahara.org/#/c/9567/14, https://reviews.mahara.org/#/c/9598/10, https://reviews.mahara.org/#/c/9604/10)
* Safari on macbook pro MoJave (10.14.1) on latest version of master

[Kevin Dibble (digitalskill)]

Thanks Liam,

It may have been a cache of 18.04 which has 163px for right when I was looking at 18.10.
It did it when I switched branches, but cannot seem to replicate.

This can be closed - invalid.