.drl file should be opened at GerberView

Bug #1819754 reported by Hildo Guillardi Júnior
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Wishlist
Michael Kavanagh

Bug Description

.drl file shown at KiCad APP should be opened at GerberView by double click (.gbr file already are).

Application: kicad
Version: 5.1.0-unknown-61567d3~82~ubuntu16.04.1, release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.47.0 OpenSSL/1.0.2g zlib/1.2.8 libidn/1.32 librtmp/2.3
Platform: Linux 4.4.0-142-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.58.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.47.0
    Compiler: GCC 5.4.0 with C++ ABI 1009

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Changed in kicad:
status: New → Triaged
importance: Undecided → Wishlist
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

It makes more sense to me to open the drill file in GerbView rather than a text editor. I'm fine with merging this patch. Anyone else have any objections?

Revision history for this message
Seth Hillbrand (sethh) wrote :

Makes sense. We can probably add a right-click "Open in text editor" option to all files later to support the original behavior.

Revision history for this message
Jeff Young (jeyjey) wrote :

+1

Revision history for this message
Hildo Guillardi Júnior (hildogjr) wrote :

@wayne, totally agree

Revision history for this message
Hildo Guillardi Júnior (hildogjr) wrote :

@seth, since I use Linux and notepad++ on Windows, I always had this right click option.
May be interesting but, I don't remember how many times I opened the gerbers / drill files in a text editor (maybe I just used for report issues here, never as a common kicad user).

Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

@Seth this option already exists for all files along with Rename and Delete ;) See kicad/tree_project_frame.cpp:725

Revision history for this message
Seth Hillbrand (sethh) wrote :

Good call. Thanks for the headsup

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

@Michael, I merged your patch into the master and 5.1 branches. Thanks.

Changed in kicad:
milestone: none → 5.1.1
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision b681e4a68e11c670739254ae944bd20aae6f7f70
https://git.launchpad.net/kicad/patch/?id=b681e4a68e11c670739254ae944bd20aae6f7f70

Changed in kicad:
status: Triaged → Fix Committed
assignee: nobody → Michael Kavanagh (michaelkavanagh)
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.