sqlalchemy-driver: Whole service stops working if DB connection is not working

Bug #1819433 reported by Thomas Bechtold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
osprofiler
Fix Released
Undecided
Thomas Bechtold

Bug Description

When setting up osprofiler with the sqlalchemy driver, the whole service (eg. keystone, nova, ...) can be killed when eg. the connection string for the database is not correct.

This is not good. The service should continue to work even if there is a problem with initializing/using osprofiler.

Revision history for this message
Thomas Bechtold (toabctl) wrote :
Changed in osprofiler:
assignee: nobody → Thomas Bechtold (toabctl)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to osprofiler (master)

Reviewed: https://review.openstack.org/642407
Committed: https://git.openstack.org/cgit/openstack/osprofiler/commit/?id=add4794120fa7cfbc1be1b6b804298a95da1b5ff
Submitter: Zuul
Branch: master

commit add4794120fa7cfbc1be1b6b804298a95da1b5ff
Author: Thomas Bechtold <email address hidden>
Date: Mon Mar 11 11:20:19 2019 +0100

    Don't fail if sqlalchemy driver fails to initialize

    Given that the driver is initialized during the service
    startup (eg. like Keystone, Nova, ...) a osprofiler driver failure has
    a huge impact on the service (when the driver fails, the whole service
    is not usable).
    We want to avoid that and just log error/exceptions but keep the
    services running.

    Change-Id: I5688f10364884a74b7eb44c0c8bda15730ccd424
    Closes-Bug: 1819433

Changed in osprofiler:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/osprofiler 2.7.0

This issue was fixed in the openstack/osprofiler 2.7.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.