Delete button doesn't remove items on Mac OS X

[KiCad bug report]

A selected item (line, text, rectangle...) does not get deleted when pushing the delete-button on Mac OS X (see below for version details). Items can only be removed with the context-menu's (right-click) 'remove'-option, or in the design list on the left of the interface.
On Windows, the delete-button seems to perform this action as expected.

Application: pl_editor
Version: (5.0.2-5)-5, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.0.20 zlib/1.2.11 nghttp2/1.24.0
Platform: Mac OS X (Darwin 17.7.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.51.0
    Compiler: Clang 8.0.0 with C++ ABI 1002
Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

You can fix some of these by changing the Hotkey from Delete to Backspace, but only some of them.

[Jeff Young (jeyjey)]

Note that it's not just the Page Layout Editor; Eeschema and Pcbnew also have this issue in places.

[Seth Hillbrand (sethh)]

Cmd+Delete should work

[KiCad bug report (kicad-bug-report)]

Hi Sethh,

for Mac that would rather be "Fn + Backspace = Delete".

So I gave it a try...
In the pl-editor, text and bitmaps can be deleted with "Fn+Backspace" after selection.
However, for lines and rectangles, it doesn't work.

[Michael Kavanagh (michaelkavanagh)]

This should make everything deletable using the delete key (Fn+backspace on Mac). Also I fixed a stray assert from the move of the zoom tools to the modern toolset.

This tested ok on:

Application: kicad
Version: (5.1.0-353-g1426a4f3c-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.5.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 10.0.1 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[jean-pierre charras (jp-charras)]

@Michael,
I committed your fix only to the master branch. Thanks.

The patch does not apply against the stable (5.13) branch.

[Michael Kavanagh (michaelkavanagh)]

@JP, thanks. I forgot the wxITEM_CHECK fix would cause a conflict with the 5.1 branch. The attached excludes that for the 5.1 branch if it's still possible to get it merged.

Cheers,
Michael

[jean-pierre charras (jp-charras)]

@Michael,
I just committed your second fix to the stable 5.1.3 branch. Thanks.