[ICL] S0ix Enabling

[quanxian]

Description:

S0ix-states represent the residency in the Intel® SoC idle standby power states.
The S0ix states shut off part of the SoC when they are not in use. The S0ix
states are triggered when specific conditions within the SoC have been achieved,
for example: certain components are in low power states. The SoC consumes the
least amount of power in the deepest (for example, S0i3) state.

S0ix is triggered by two paths:
(1) by system PM, e.g "suspend-to-idle" triggered by pressing the power button
on Android device or command manually triggered on any Linux based distros;

(2) by runtime PM, i.e no system activities with display off.

S0ix should simply work in theory with trigger path (1) if we have the device
drivers ready. On GLK, we require the below PCI device drivers with system PM
support. ACPI device requirements are WIP.

 I2C designware PCI driver
 USB XHCI PCI ID
 Intel trace Hub[NPK) PCI ID
 SPI BXT PCI ID
 SCSI UFS BXT PCI host ID
 Graphics
 Audio
 PWM
 HSUART
 Security engine

S0ix with trigger path (2) require work as defined below.
 All the above device drivers need to support runtime PM (already defined in the same LCK above)
 PCI root port to support runtime PM

Both paths will require intel_idle driver support for S0ix support.

238f9c11351f8af8534ae0318b4d9acc77b09ee8

8aba056a4ea6da18186025a335a96b2f071e69d3

6769fdbe27d782dfee5e459e25b44baacc7c8459

cfb55af9add9c19806300fdb31f4cd25e67c6d1a

4a5861f714293767980e4948c9a7c9e5e09c9b94

2a13096ac7da07a1bfc9d91fc4a982020e7ded2b

cd89e92b7399a69512b8d855a2dd145c47399bf8

d6827015e671cd17871c9b7a0fabe06c044f7470

0e68eeea9894feeba2edf7ec63e4551b87f39621

e50af8332785355de3cb40d9f5e8c45dbfc86f53

Target Kernel: 5.1
Target Release: 19.10

SRU Justification
[Impact]
Requires patches to make new INTEL CPU IceLake support s0ix
[Fix]
The patch list is provided by Intel
   238f9c11351f platform/x86: intel_pmc_core: Quirk to ignore XTAL
shutdown
   8aba056a4ea6 platform/x86: intel_pmc_core: Add Package cstates residency info
   6769fdbe27d7 platform/x86: intel_pmc_core: Add ICL platform support
   cfb55af9add9 platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro
   4a5861f71429 platform/x86: intel_pmc_core: Avoid a u32 overflow
   2a13096ac7da platform/x86: intel_pmc_core: Include Reserved IP for LTR
   cd89e92b7399 platform/x86: intel_pmc_core: Fix file permissions for ltr_show
   d6827015e671 platform/x86: intel_pmc_core: Fix PCH IP name
   0e68eeea9894 platform/x86: intel_pmc_core: Fix PCH IP sts reading
   e50af8332785 platform/x86: intel_pmc_core: Handle CFL regmap properly

Below commit fix 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
   9ae11e237d95 platform/x86: intel_pmc_core: Mark local function static

[Test]
Verified on Intel ICL-Y SDP with fwts s2idle test 30 times, the system is still working.

[Regression Risk]
Low. Those patches are all small changes, and most of them are adding IDs, should be safe to include them.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1819413

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[AceLan Kao (acelankao)]

Those commits doesn't affect the power consumption on Intel ICL-Y SDP(alpha), so I'm not sure if they help on power consumption on real products.

[AceLan Kao (acelankao)]

On Intel ICL-Y SDP(alpha):
Before patched
short idle: 13.46w
long idle: 12.94w
s2idle: 12.67w

After patched:
short idle: 13.45w
long idle: 13.06w
s2idle: 12.87w

[AceLan Kao (acelankao)]

The pmc_core commits listed in this bug have been submitted to oem-osp1-b kernel
https://lists.ubuntu.com/archives/kernel-team/2019-July/102063.html

That means, there is no other commits in the bug require us to submit to oem kernel.

[Timo Aaltonen (tjaalton)]

oem-osp1 was handled via bug 1836012, and 19.10 ships with 5.3