next share_links contains not supported marker field

[Chuan Miao]

when querying the endpoint /shares, a field share_links is returned in the response. It contains the next link, which has the marker field as shown below. It's confusing, because marker is not supported. And when querying the link, it doesn't return the "next" shares as the name suggests.

```
"shares_links": [
        {
            "href": "https://sth.com/v2/05f9781218b7401d9955f9b8a05a5aea/shares?limit=1&marker=56a8b778-47fc-45aa-bb5f-7950e2131331",
            "rel": "next"
        }
    ],
"shares": [
  ...
],
```

[Jason Grosso (jgrosso)]

Goutham has the train left :)

[Goutham Pacha Ravi (gouthamr)]

Thanks for the reminder Jason :) Targeting this to Ussuri-2

[Victoria Martinez de la Cruz (vkmc)]

This is better done as an API microversion bump since we will be changing what the API returns, generating breakage or a very inconsistent behavior. Let's push this for next cycle and ensure consistency across other resources (snapshots, groups, replicas, etc)

[Victoria Martinez de la Cruz (vkmc)]

Tried to reproduce this on master

stack@xena:~$ curl -i -X GET http://192.168.122.98/share/v2/shares -H "X-Openstack-Manila-Api-Version: 2.65" -H "X-Auth-Token: $AUTH_TOKEN" -H "Content-Type: application/json" -H "Accept: application/json" -H "User-Agent: python-manilaclient"
HTTP/1.1 200 OK
Date: Mon, 13 Dec 2021 14:35:18 GMT
Server: Apache/2.4.41 (Ubuntu)
Content-Type: application/json
Content-Length: 1162
x-compute-request-id: req-53571d63-ee3f-4105-8c74-cef23fc73ecf
X-OpenStack-Manila-API-Version: 2.65
Vary: X-OpenStack-Manila-API-Version
Connection: close

{
   "shares":[
      {
         "id":"724604c3-ba7c-4133-b5ef-7f6007ca2c93",
         "name":"carloss-test",
         "links":[
            {
               "rel":"self",
               "href":"http://192.168.122.98/share/v2/shares/724604c3-ba7c-4133-b5ef-7f6007ca2c93"
            },
            {
               "rel":"bookmark",
               "href":"http://192.168.122.98/share/shares/724604c3-ba7c-4133-b5ef-7f6007ca2c93"
            }
         ]
      },
      {
         "id":"25332e9d-babe-4a21-8f1b-091242c1a69d",
         "name":"gouthamr-test",
         "links":[
            {
               "rel":"self",
               "href":"http://192.168.122.98/share/v2/shares/25332e9d-babe-4a21-8f1b-091242c1a69d"
            },
            {
               "rel":"bookmark",
               "href":"http://192.168.122.98/share/shares/25332e9d-babe-4a21-8f1b-091242c1a69d"
            }
         ]
      },
      {
         "id":"1606060a-e5b0-42c6-b953-367c9f93be34",
         "name":"vkmc-test",
         "links":[
            {
               "rel":"self",
               "href":"http://192.168.122.98/share/v2/shares/1606060a-e5b0-42c6-b953-367c9f93be34"
            },
            {
               "rel":"bookmark",
               "href":"http://192.168.122.98/share/shares/1606060a-e5b0-42c6-b953-367c9f93be34"
            }
         ]
      },
      {
         "id":"103534dc-d8f7-432f-a33e-39b014370794",
         "name":"francie-test",
         "links":[
            {
               "rel":"self",
               "href":"http://192.168.122.98/share/v2/shares/103534dc-d8f7-432f-a33e-39b014370794"
            },
            {
               "rel":"bookmark",
               "href":"http://192.168.122.98/share/shares/103534dc-d8f7-432f-a33e-39b014370794"
            }
         ]
      }
   ]
}

I'm not getting shares_links, and the links that are listed are working. Maybe this was an issue in Train?

[Carlos Eduardo (silvacarlose)]

Was about to re-target this, but I think we should have some level of confirmation on this bug in older branches. Do we have a confirmation of this bug in Train?

[Victoria Martinez de la Cruz (vkmc)]

I'll check this on Train and report the results

[Launchpad Janitor (janitor)]

[Expired for OpenStack Shared File Systems Service (Manila) because there has been no activity for 60 days.]