OpenStack Compute (nova)

Should not skip volume_size check for bdm.image_id == image_ref case

Bug #1818798 reported by Zhenyu Zheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Zhenyu Zheng
Stein
Fix Released
Low
Unassigned

Bug Description

The volume size should be checked in bdm.sourece_type=image, dest_type=volume case no matter what the image
is, but in:
https://github.com/openstack/nova/blob/5a09c81af3b438ecbcf27fa653095ff55abb3ed4/nova/compute/api.py#L1452-L1453
we skipped the check if the bdm.image_id == image_ref, it was meant to skip only the _get_image() check as it
is already checked before, but it skipped the volume_size check too.

Tags: api volumes
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/641282

Changed in nova:
assignee: nobody → Zhenyu Zheng (zhengzhenyu)
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: api volumes
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/641282
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=24fe74d126f23bea56c87524b1005a2aaacb870c
Submitter: Zuul
Branch: master

commit 24fe74d126f23bea56c87524b1005a2aaacb870c
Author: Kevin_Zheng <email address hidden>
Date: Wed Mar 6 16:48:10 2019 +0800

    Should not skip volume_size check for bdm.image_id == image_ref case

    The volume size should be checked in bdm.sourece_type=image,
    dest_type=volume case no matter what the image
    is, but we skipped the check if the bdm.image_id == image_ref,
    we should not skipped the volume_size check.

    Change-Id: Ib10579280b63a4dd59ac76733aa0ff48fd2e024b
    closes-bug: 1818798

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/744553

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/744553
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=33c8e5473d56ae225dd70565ce637b0106537aab
Submitter: Zuul
Branch: stable/stein

commit 33c8e5473d56ae225dd70565ce637b0106537aab
Author: Kevin_Zheng <email address hidden>
Date: Wed Mar 6 16:48:10 2019 +0800

    Should not skip volume_size check for bdm.image_id == image_ref case

    The volume size should be checked in bdm.sourece_type=image,
    dest_type=volume case no matter what the image
    is, but we skipped the check if the bdm.image_id == image_ref,
    we should not skipped the volume_size check.

    Change-Id: Ib10579280b63a4dd59ac76733aa0ff48fd2e024b
    closes-bug: 1818798
    (cherry picked from commit 24fe74d126f23bea56c87524b1005a2aaacb870c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.