Web staff client, cannot add items to CONS, but Evergreen allows users to try to anyway

[Sören Hakola]

Hi,
Just downloaded the software and installed in order to evaluate Evergreen system.

I'm using web staff client with Firefox 65.0.1 on Ubuntu (laptop).
Evergreen version is 3.2.4.
Osrf version is 3.0.2
OS is debian stretch (desktop machine)
PostgreSQL version 9.6

When added marc record I want to add an item. This I do by either selecting tick at "Add item" or pushing button "Add holdings". The holdings page shows and I can input necessary information. But when pushing button "Save and exit" nothing happens except that the list of items is emptied. The information is NOT stored. I.e. search on barcode gives nothing.

The javascript console shows following when pushing "Save and exit" button:

error calling method open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for session [0.23366097649896611551530595846], thread trace [0]:
Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185.

core.bundle.js:1:6577

    onmethoderror https://evergreen/js/ui/default/staff/build/js/core.bundle.js:1 handle_message4Dojo

Possibly unhandled rejection: error calling method open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for session [0.23366097649896611551530595846], thread trace [0]:
Can't call method "isdeleted" on unblessed reference at /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185.

vendor.bundle.js:6:63212

Am I missing something or is the save routine broken?

Greetings,
Sören
Finland

[Jane Sandberg (sandbergja)]

Hi Sören! Thanks for your report. Just to check, what is the value in the "Owning Library" dropdown (see attached screenshot)? The "Save and Exit" button will fail if you attempt to add holdings to a consortium or system, rather than an individual library or branch. Could you please try it again using a different Owning Library?

Typically, this owning library combobox wouldn't allow users to select invalid values. But when I log in as the egadmin account, I'm able to create a workstation at the consortium level, and then use that consortium-level workstation to attempt to create holdings attached to the consortium, rather than a specific library or branch.

[Sören Hakola (soren-hakola)]

Hi,

Thanks a lot for the help! Now I have it working.

I tried to put an item on CONS level, which doesn't allow holdings. Now I
understand the logics. I.e. no bug, just did not see the logic around the
organizational units.

Have a nice day,
Sören

Den lör 2 mars 2019 kl 19:35 skrev Jane Sandberg <email address hidden>:

> Hi Sören! Thanks for your report. Just to check, what is the value in
> the "Owning Library" dropdown (see attached screenshot)? The "Save and
> Exit" button will fail if you attempt to add holdings to a consortium or
> system, rather than an individual library or branch. Could you please
> try it again using a different Owning Library?
>
> Typically, this owning library combobox wouldn't allow users to select
> invalid values. But when I log in as the egadmin account, I'm able to
> create a workstation at the consortium level, and then use that
> consortium-level workstation to attempt to create holdings attached to
> the consortium, rather than a specific library or branch.
>
> ** Attachment added: "owning_library.png"
>
> https://bugs.launchpad.net/evergreen/+bug/1818332/+attachment/5242852/+files/owning_library.png
>
> ** Tags added: cataloging webstaffclient
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1818332
>
> Title:
> Web staff client, cannot add items
>
> Status in Evergreen:
> New
>
> Bug description:
> Hi,
> Just downloaded the software and installed in order to evaluate
> Evergreen system.
>
> I'm using web staff client with Firefox 65.0.1 on Ubuntu (laptop).
> Evergreen version is 3.2.4.
> Osrf version is 3.0.2
> OS is debian stretch (desktop machine)
> PostgreSQL version 9.6
>
>
> When added marc record I want to add an item. This I do by either
> selecting tick at "Add item" or pushing button "Add holdings". The holdings
> page shows and I can input necessary information. But when pushing button
> "Save and exit" nothing happens except that the list of items is emptied.
> The information is NOT stored. I.e. search on barcode gives nothing.
>
> The javascript console shows following when pushing "Save and exit"
> button:
>
> error calling method
> open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call
> to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for
> session [0.23366097649896611551530595846], thread trace [0]:
> Can't call method "isdeleted" on unblessed reference at
> /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185.
>
> core.bundle.js:1:6577
>
> onmethoderror
> https://evergreen/js/ui/default/staff/build/js/core.bundle.js:1
> handle_message4Dojo
>
> Possibly unhandled rejection: error calling method
> open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call
> to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for
> session [0.23366097649896611551530595846], thread trace [0]:
> Can't call method "isdeleted" on unblessed reference at
> /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185.
>
> vendor.bundle.js:6:63212
>
>
> Am I missing something or is the save rout...

[Jane Sandberg (sandbergja)]

So glad that it's working, Sören. I do want to leave this bug open, because it does make it more difficult for people to evaluate Evergreen.

As I see it, users shouldn't be able to create a CONS level workstation in the first place, so that's the real bug. It might also be good to offer users some meaningful feedback about why their holdings were not created in this case, though.

[Andrea Neiman (aneiman)]

I may be wrong but I think this only happens when using the master admin login, because that is a special case as it "lives" at CONS.

[Jane Sandberg (sandbergja)]

I think you're right, Andrea. Unfortunately, the master admin login is the one that people testing out the system are most likely to be using. :-(

[Andrea Neiman (aneiman)]

Fair. I believe there are Actual Reasons for having that login owned at CONS, so perhaps this should be considered a documentation bug?

[Tiffany Little (tslittle)]

+1 to considering this a documentation bug. Almost anything's okay as long as you document it. ;)

[Jane Sandberg (sandbergja)]

How about documentation at the point of need: like a little informative alert on the workstation admin screen that pops up when egadmin attempts to create a workstation at the CONS level? Brand new users tend to get confused at the workstation registration screen anyway, so I'd prefer something that doesn't require them to look in the documentation first.

[Andrea Neiman (aneiman)]

That's a good point, Jane -- +1 to some manner of in-place alert for this

[Sören Hakola (soren-hakola)]

Hi,

Perhaps unnecessary comment, but just to remind you:

With a fresh install you have no other option than to login as CONS, since
there are no other organizations created during install. There should be a
documentation / tutorial on how to create a new organization unit and why.
This is not a very intuitive process and needs instructions.

Or can the installation create a default sub organization that can hold
items?

Best regards,
Sören

Den tors 7 mars 2019 kl 01:41 skrev Andrea Neiman <
<email address hidden>>:

> That's a good point, Jane -- +1 to some manner of in-place alert for
> this
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1818332
>
> Title:
> Web staff client, cannot add items to CONS, but Evergreen allows users
> to try to anyway
>
> Status in Evergreen:
> New
>
> Bug description:
> Hi,
> Just downloaded the software and installed in order to evaluate
> Evergreen system.
>
> I'm using web staff client with Firefox 65.0.1 on Ubuntu (laptop).
> Evergreen version is 3.2.4.
> Osrf version is 3.0.2
> OS is debian stretch (desktop machine)
> PostgreSQL version 9.6
>
>
> When added marc record I want to add an item. This I do by either
> selecting tick at "Add item" or pushing button "Add holdings". The holdings
> page shows and I can input necessary information. But when pushing button
> "Save and exit" nothing happens except that the list of items is emptied.
> The information is NOT stored. I.e. search on barcode gives nothing.
>
> The javascript console shows following when pushing "Save and exit"
> button:
>
> error calling method
> open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call
> to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for
> session [0.23366097649896611551530595846], thread trace [0]:
> Can't call method "isdeleted" on unblessed reference at
> /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185.
>
> core.bundle.js:1:6577
>
> onmethoderror
> https://evergreen/js/ui/default/staff/build/js/core.bundle.js:1
> handle_message4Dojo
>
> Possibly unhandled rejection: error calling method
> open-ils.cat.asset.volume.fleshed.batch.update.override : 500 : *** Call
> to [open-ils.cat.asset.volume.fleshed.batch.update.override] failed for
> session [0.23366097649896611551530595846], thread trace [0]:
> Can't call method "isdeleted" on unblessed reference at
> /usr/local/share/perl/5.24.1/OpenILS/Application/Cat.pm line 1185.
>
> vendor.bundle.js:6:63212
>
>
> Am I missing something or is the save routine broken?
>
> Greetings,
> Sören
> Finland
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1818332/+subscriptions
>

[Jason Stephenson (jstephenson)]

You can add sample data, complete with an org tree, users, and items if you add the --load-all-sample option to the eg_db_config step as mentioned in the README. This data is not ideal for production use, but can be used for kicking the tires and is required for running the Evergreen automated tests. There is documentation on the users added with the sample data set here:

http://wiki.evergreen-ils.org/doku.php?id=qa:concerto_logins

Years ago, I started a page on the dokuwiki to document the first steps that one needs to take when setting up a fresh Evergreen installation https://wiki.evergreen-ils.org/doku.php?id=scratchpad:setup . Unfortunately, other tasks got in the way and the page has sat there, neglected, for over 8 years.

There is a book that was published a few years ago to help people get started with Evergreen. It is available at FLOSS manuals among other places: http://write.flossmanuals.net/evergreen-in-action/acknowledgements/

I haven't looked at the actual Evergreen documentation for a while, so I'm not sure what is there to actually help people get their new Evergreen installation set up, but here's a link to that as well.

http://docs.evergreen-ils.org

[Mike Rylander (mrylander)]

AFAICT, the workstation registration issue is indeed a regression from 3.1, which restricted that to those OUs with can_have_users set to true. I suspect a problem with the OU flag checks and disabling selection when they (can_have_users and can_have_vols) was introduced when the widget was improved between 3.1 and 3.3 to add type-to-search and the like.

There definitely are good reasons a site might have for allowing WS registration (and copy ownership) at any level of the hierarchy, but restriction should also be possible.