[rocky, queens] Invalid Cinder API v1 entries in keystone catalog

[Alan Bishop]

Cinder's API v1 was completely removed during the queens cycle [1], but TripleO continued to create a keystone service and endpoint. This is fixed in stein in puppet-cinder [2], but that patch is unsuitable for backporting (it deprecates some puppet parameters).

[1] https://review.openstack.org/499342
[2] https://review.openstack.org/636456

This bug addresses problem that exists in rocky and queens.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/640480

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/640480
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9ae5fd8f35bb9c337f040b7181eb3b66ae04ffc8
Submitter: Zuul
Branch: stable/rocky

commit 9ae5fd8f35bb9c337f040b7181eb3b66ae04ffc8
Author: Alan Bishop <email address hidden>
Date: Fri Mar 1 12:48:18 2019 -0500

    Don't create service or endpoint for cinder API v1

    Cinder removed support for API v1 in Queens [1], so don't create the
    keystone service or endpoint for v1.

    Existing keystone catalog entries for v1 are not removed. It is the
    user's responsibility for removing them.

    This issue is fixed in stein [2], but requires a different solution in
    rocky and queens. The keystone endpoint is easily suppressed by setting
    the corresponding cinder::keystone::auth::configure_endpoint hiera value
    False. However, puppet-cinder has no corresponding "configure_service"
    flag, so instead the service_name, service_type and service_description
    hiera values are set to match the corresponding API v3 values.

    [1] https://review.openstack.org/499342
    [2] https://review.openstack.org/636456

    Closes-Bug: 1818273
    Change-Id: Ia9bc71f62ba9dac591be18a1b4229f879c319956

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/644550

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/644550
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=86c8de92b3ac5758b152dc0c1f996f5d9c7aab38
Submitter: Zuul
Branch: stable/queens

commit 86c8de92b3ac5758b152dc0c1f996f5d9c7aab38
Author: Alan Bishop <email address hidden>
Date: Fri Mar 1 12:48:18 2019 -0500

    Don't create service or endpoint for cinder API v1

    Cinder removed support for API v1 in Queens [1], so don't create the
    keystone service or endpoint for v1.

    Existing keystone catalog entries for v1 are not removed. It is the
    user's responsibility for removing them.

    This issue is fixed in stein [2], but requires a different solution in
    rocky and queens. The keystone endpoint is easily suppressed by setting
    the corresponding cinder::keystone::auth::configure_endpoint hiera value
    False. However, puppet-cinder has no corresponding "configure_service"
    flag, so instead the service_name, service_type and service_description
    hiera values are set to match the corresponding API v3 values.

    [1] https://review.openstack.org/499342
    [2] https://review.openstack.org/636456

    Closes-Bug: 1818273
    Change-Id: Ia9bc71f62ba9dac591be18a1b4229f879c319956
    (cherry picked from commit 9ae5fd8f35bb9c337f040b7181eb3b66ae04ffc8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.