Wishlist: Pre fill Preferences > Live Broadcasting > Stream Settings > Stream name value

Bug #1818054 reported by Terry Belton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Sanskar Bajpai

Bug Description

Many Mixx users connect to Shoutcast 2 servers.

In "Preferences > Live Broadcasting > Stream Settings" there are 4 variables.

They are "Stream name", "Website", "Description" and "Genre".

The Mixxx manual says:

"Mixxx works with Shoutcast 2 using the Shoutcast 1 protocol if you provide a stream name in Preferences ‣ Live Broadcasting ‣ Stream Settings. If you don’t provide a stream name, Shoutcast 2 rejects the connection (where Shoutcast 1 would accept this case)."

Out of the box, the 1st, "Stream name" is blank. This trips up people that do not read the manual or forget.

I suggest the default mixxx.cfg file is modified....

From:

[Shoutcast]
...
stream_name
stream_website http://www.mixxx.org
stream_desc This stream is online for testing purposes!
stream_genre Live Mix
...

to:

[Shoutcast]
...
stream_name Mixxx
stream_website http://www.mixxx.org
stream_desc This stream is online for testing purposes!
stream_genre Live Mix
...

Something like this in diff should do it:

- stream_name
+ stream_name Mixxx

Revision history for this message
Daniel Schürmann (daschuer) wrote :

I would be happy to receive a GitHub Pull Request.

Changed in mixxx:
status: New → Confirmed
importance: Undecided → Medium
tags: added: usability
tags: added: easy
Revision history for this message
Terry Belton (tezzy) wrote :

I looked in to this, it is more involved. The configuration file is created when Mixxx is run for the first time AND OR and or updated when Mixxx is upgraded.

Sorry, I am "out of my depth" to make a change.

Revision history for this message
Sanskar Bajpai (pawbud) wrote :

I have been trying to find the mixxx.cfg file, May I please be guided with a relevant path(I tried searching for the file on github too)?

Revision history for this message
ronso0 (ronso0) wrote :

this is the file where the dialog is set up and processed:
https://github.com/mixxxdj/mixxx/blob/master/src/preferences/dialog/dlgprefbroadcast.cpp
and the GUI file:
https://github.com/mixxxdj/mixxx/blob/master/src/preferences/dialog/dlgprefbeatsdlg.ui

IIRC, after first start, there's IceCast selected in Pref > Live Broadcasting.
For the case mentioned (switch to shoutcast) you'd need to fill `stream_name` field with a placeholder.

Revision history for this message
Sanskar Bajpai (pawbud) wrote :

i am not very familiar with XML but I tried to put a `property` tag with the name attribute and it didn't work.

Revision history for this message
Sanskar Bajpai (pawbud) wrote :

I did switch to shoutcast and yet it didn't work, on top of that what if I tried putting a `QString kDefaultStreamName=QObject::tr("Mixxx")`, in here https://github.com/PawBud/mixxx/blob/master/src/preferences/broadcastprofile.cpp#L79, It was wrong but would you mind telling me what this file does then?

Revision history for this message
ronso0 (ronso0) wrote :

I'd say you also need to pick that default name here, instead of empty QString:
https://github.com/PawBud/mixxx/blob/master/src/preferences/broadcastprofile.cpp#L240

Discussion details is much easier in Zulip, so please head over to https://mixxx.zulipchat.com/

Revision history for this message
ronso0 (ronso0) wrote :

... and open a new thread in the development stream
https://mixxx.zulipchat.com/#narrow/stream/109171-development

ronso0 (ronso0)
tags: added: broadcast
Revision history for this message
Sanskar Bajpai (pawbud) wrote :

Alright, Thanks a lot :)

Revision history for this message
Daniel Schürmann (daschuer) wrote :
ronso0 (ronso0)
Changed in mixxx:
milestone: none → 2.3.0
status: Confirmed → Fix Committed
assignee: nobody → Sanskar Bajpai (pawbud)
Revision history for this message
Terry Belton (tezzy) wrote :

Please excuse the delay the notification email went in the spam folder.

Thanks everybody for fixing this bug.

Best wishes.

Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9605

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.