Change section in debian/control and fix .desktop files

Bug #181782 reported by Kirill Chunaev
6
Affects Status Importance Assigned to Milestone
zsnes (Ubuntu)
Fix Released
Wishlist
Kirill Chunaev

Bug Description

Binary package hint: zsnes

I'd like official maintainer (or somebody else who can) to rebuild zsnes package for Hardy realease using my improved deb-control and .desktop files. New .desktop file is a modified version of native .desktop from tarball of zsnes. I've only removed "Path" section and corrected "Comment" section. New deb-control file is a modified version of deb-control from last Hardy zsnes package. I've corrected "Section" area and "Description" area. My improvements will make zsnes package in Ubuntu more good-looking for newbies. Also my imrovements corrects some innacuracies and luxuries.
If you don't agree some of my corrections, please explain me why.

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

I see that your .desktop file is not ok. If you run a desktop-file-validate on it you will have this output:

zsnes.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
zsnes.desktop: error: value "zsnes.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
zsnes.desktop: warning: value "Application;Game;Emulator;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"

Thank you for your work.

Revision history for this message
Kirill Chunaev (kirchun) wrote :

Thanks for your advices, Mario! I've corrected all errors in my .desktop file.

description: updated
Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Now it looks better; I think that you should forward this suggestion (I mean the .desktop file) upstream, because it's better to have the changes included there. However, feel free to submit a debdiff if you think the changes are needed. :)

Revision history for this message
Kirill Chunaev (kirchun) wrote :

I'm sorry, but I don't have enough experience. What should I do to forward my suggestions about deb-control and .desktop files upstream? I must make patches for these two files and add them to this bugreport, mustn't it?

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Yes, if you want to get this changes included in Ubuntu you should make a patch (a debdiff) and attach it here. However, (I'm speaking mostly for the .desktop file), it would be nice to have the change included at least in Debian, if it is really necessary. Is that clearer? :)

Revision history for this message
Kirill Chunaev (kirchun) wrote :

Yes, it's clear now about .desktop file. But what about deb-control file? How can I do the patch? And why should I do any changes in Debian as I use Ubuntu? Who is the official maintainer of zsnes package in Ubuntu? I'm only simple user of Ubuntu and I haven't enough time to become a maintainer for now. I thought that open-source world doesn't based on the bureaucracy... Building a package is a deal of five minutes. Is it too hard for maintainer? Should I do it by myself, because maintainer is too lazy? Maybe we will help each other to make Ubuntu much more comfortable?

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

1) to provide a patch I would do:
    - download the package source with apt-get source zsnes
    - put the updated files into the package
    - update debian/changelog with an explanation of the changes
    - build the source package and make a debdiff between the old dsc and the new one
2)the package in Ubuntu are merged and synced from Debian so if the changes are included in Debian, they will soon be present in Ubuntu
3)we don't have the concept of unique maintainer like Debian for the majority of packages

Revision history for this message
Kirill Chunaev (kirchun) wrote :

OK. It wasn't so hard, because I've been working with RPM system in the past.
So...
http://kirchun1.narod.ru/debian/zsnes_1.510-2.1.debdiff
http://kirchun1.narod.ru/debian/zsnes_1.510-2.1.dsc
http://kirchun1.narod.ru/debian/zsnes_1.510-2.1.diff.gz
http://kirchun1.narod.ru/debian/zsnes_1.510-2.1_source.build
http://kirchun1.narod.ru/debian/zsnes_1.510-2.1_source.changes

Could you help me to add this work to Debian and Ubuntu (packages are identical in both repositories)? I can't do it by myself...

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

There is no need to upload all that stuff, it is only necessary to upload the debdiff; remember to check "This attachment is a patch" option is enabled. If you want to include the changes in Ubuntu subscribe Ubuntu-universe-sponsors to this bug report, someone will check the changes. As regards Debian, you should open there a bug report.

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Good, subscribe ubuntu-universe-sponsors if you want to go on. :)

Revision history for this message
Kirill Chunaev (kirchun) wrote :

I don't know how to do it. Can you do it by yourself as this bug is related to you? What's wrong?

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

Why should this bug be related to me?

Revision history for this message
Mb (mb-deactivatedaccount-deactivatedaccount-deactivatedaccount) wrote :

However, to subscribe u-u-s, click subscribe someone else from the panel on the left and add ubuntu-universe-sponsors

Revision history for this message
Kirill Chunaev (kirchun) wrote :

See: https://bugs.launchpad.net/~mariobonino
Press "Ctrl+F", write "zsnes" and press "Enter" button ;-)

Revision history for this message
Luca Falavigna (dktrkranz) wrote :

You should prepare a new debdiff:
 * Target must be hardy, not unstable
 * Version must be 1.510-2ubuntu1
 * You should modify Maintainer field following these rules: https://wiki.ubuntu.com/DebianMaintainerField
Also, you may want to install patchutils package to avoid showing /tmp/something in your debdiff.

Please, resubscribe ubuntu-universe-sponsors when a new debdiff will be available. Thanks :)

Changed in zsnes:
assignee: nobody → kirchun
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Kirill Chunaev (kirchun) wrote :
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Debdiff looks good.
Could you please file a new bug in Debian? This way we could sync on a later stage.
Eventually, you can coordinate with William in bug #184255 to provide two fixes in the same upload.

Changed in zsnes:
assignee: kirchun → nobody
importance: Low → Wishlist
status: In Progress → Confirmed
Revision history for this message
Siegfried Gevatter (rainct) wrote :

I'm unsubscribing ubuntu-universe-sponsors in regards to Luca's comment. Thanks for contributing to Ubuntu :).

description: updated
Changed in zsnes:
assignee: nobody → nenolod
status: Confirmed → In Progress
Kirill Chunaev (kirchun)
Changed in zsnes:
assignee: nenolod → kirchun
status: In Progress → Fix Committed
Philipp Kern (pkern)
Changed in zsnes:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.