[FwaasV1] Updating a ip address in firewall rule demands ip-version though it was accepted as default ipv4 while creating the rule

[Bharath bhushan Patel]

Created a Firewall-rule with the following specifications
protocol: icmp
action: allow
destination-ip-address: 192.168.1.110
and while creating we dont have to specify any ip-version but while i try to update the same rule's destination ip, it asks for the ip-version

the firewall-rule-ip is
root@loadbalancer01:~# neutron firewall-rule-show rx-100
+------------------------+--------------------------------------+
| Field | Value |
+------------------------+--------------------------------------+
| action | allow |
| description | |
| destination_ip_address | 192.168.1.110 |
| destination_port | |
| enabled | True |
| firewall_policy_id | deac8377-7e08-4dc8-a5f6-1f9e07f4aa9d |
| id | 89ddd54c-cb1f-4274-941e-ee0d11f9e36e |
| ip_version | 4 |
| name | rx-100 |
| position | 1 |
| project_id | 79e547b4eb6b43e287138dd7688a00e7 |
| protocol | icmp |
| shared | False |
| source_ip_address | |
| source_port | |
| tenant_id | 79e547b4eb6b43e287138dd7688a00e7 |
+------------------------+--------------------------------------+

but when i try to update:
root@loadbalancer01:~# neutron firewall-rule-update --destination-ip-address 192.168.1.121 --protocol icmp rx-100
Invalid input - IP addresses do not agree with IP Version
Neutron server returns request_ids: ['req-f7df645c-e097-4b27-92a0-f94310106a06']

this must be handled in the fwaas driver to consider default as ip-versio 4 , as its while creating.

[Akihiro Motoki (amotoki)]

Which release do you use?
FWaaS v1 API was dropped in the development version, so we need more detail input.

[Bharath bhushan Patel (pbharathbhu)]

Hi Akihiro,
It was with ocata and i dnt think there is any change in driver in latest release too,
so may be the driver needs this fix.

[zhanghao (zhanghao2)]

After my test,FWaaS_v2 have no this problem.