Creation of router fails in devstack

[Slawek Kaplonski]

Router creation failed in http://logs.openstack.org/36/638136/1/check/openstacksdk-functional-devstack/1cdc712/job-output.txt.gz#_2019-02-20_12_04_53_592956

In neutron-server log there is error like: http://logs.openstack.org/36/638136/1/check/openstacksdk-functional-devstack/1cdc712/controller/logs/screen-q-svc.txt.gz#_Feb_20_12_04_53_392346

It is possible that this could be introduced somehow by https://review.openstack.org/#/c/635671/ but it is not sure for now.

[Slawek Kaplonski (slaweq)]

I found out that the issue happens when port_forwarding service plugin is enabled. Without it, all works fine

[Slawek Kaplonski (slaweq)]

git bisect told me that culprit commit is e8b7e768a2545621ee98511b8dd271c5117f76bd which is https://review.openstack.org/#/c/626561/

I will try to debug a bit how we can fix it. But in case is it would be hard, I will propose revert also

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/638359

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/638380

[OpenStack Infra (hudson-openstack)]

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.openstack.org/638359
Reason: Better fix in https://review.openstack.org/#/c/638380/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/638391

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/638447

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638380
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d802fad8a92625005597ebda4931b0bbe13418e9
Submitter: Zuul
Branch: master

commit d802fad8a92625005597ebda4931b0bbe13418e9
Author: Slawek Kaplonski <email address hidden>
Date: Thu Feb 21 11:16:03 2019 +0100

    Avoid loading same service plugin more than once

    In patch [1] requirement that only each service plugin
    can be loaded only once was removed.
    Unfortunatelly it is not possible that same service plugin
    will be instantiate more than once because it may reqister some
    callbacks or other things which can't be duplicated.

    So this patch adds mechanism which will ensure that each service
    plugin class is instantiate only once and reused if necessary.

    [1] https://review.openstack.org/#/c/626561/

    Closes-Bug: #1816771

    Change-Id: Ie6e6cc1bbbe50ff7cfad4e8033e48711569ea020

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638391
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3f38c58cffddf7f2763455cce9d0ebf875230994
Submitter: Zuul
Branch: master

commit 3f38c58cffddf7f2763455cce9d0ebf875230994
Author: Jens Harbott <email address hidden>
Date: Thu Feb 21 10:48:15 2019 +0000

    Add job from openstacksdk to avoid regressing

    As seen in [0], openstacksdk uses a scenario for testing that isn't
    currently covered by Neutron's own testing. Add a job from their stack
    to be run on all patches, but make it non-voting to start with.

    [0] https://bugs.launchpad.net/neutron/+bug/1816771

    Change-Id: I35ba7664335026ca2a4d361d93fbf784bf0ffe5c
    Related-Bug: 1816771
    Related-Bug: 1817045

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638447
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a77cbd926018a904212f2cac0420534a5b5d2191
Submitter: Zuul
Branch: master

commit a77cbd926018a904212f2cac0420534a5b5d2191
Author: LIU Yulong <email address hidden>
Date: Thu Feb 21 23:51:06 2019 +0800

    Add test case to duplicated service plugin

    Functional test case for [1] to prevent agressive on L3 provider service.
    Related DB error: ProviderResourceAssociation.

    [1] https://review.openstack.org/#/c/638380/

    Change-Id: I95792ad6cf63d13dc790a1ec636860dde82a23c6
    Related-Bug: #1816771

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/649043

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649043
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=fb0c062899032288091df50a18f7f30a594bcc14
Submitter: Zuul
Branch: stable/rocky

commit fb0c062899032288091df50a18f7f30a594bcc14
Author: Slawek Kaplonski <email address hidden>
Date: Thu Feb 21 11:16:03 2019 +0100

    Avoid loading same service plugin more than once

    In patch [1] requirement that only each service plugin
    can be loaded only once was removed.
    Unfortunatelly it is not possible that same service plugin
    will be instantiate more than once because it may reqister some
    callbacks or other things which can't be duplicated.

    So this patch adds mechanism which will ensure that each service
    plugin class is instantiate only once and reused if necessary.

    [1] https://review.openstack.org/#/c/626561/

    Closes-Bug: #1816771

    Change-Id: Ie6e6cc1bbbe50ff7cfad4e8033e48711569ea020
    (cherry picked from commit d802fad8a92625005597ebda4931b0bbe13418e9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.4 release.