including 'OS::TripleO::Compute::PreNetworkConfig: /home/stack/templates/config_then_reboot.yaml' breaks deployment

[Alex Schultz]

Description of problem:
Including 'OS::TripleO::Compute::PreNetworkConfig: /home/stack/templates/config_then_reboot.yaml ' makes overcloud deployment faild.

The error message is
~~~
ERROR: Property error: : resources.Controller<nested_stack>.resources.0
  <http://XXXX/overcloud/puppet/controller-role.yaml>.
  resources.PreNetworkConfig.properties: : Unknown Property RoleParameters",
~~~

config_then_reboot.yaml doesn't have RoelParameters and ServiceNames in it.

Adding following paramters in parameters section in config_then_reboot.yaml resolves the issue.
~~~
  RoleParameters:
    type: json
    description: Parameters specific to the role
    default: {}
  ServiceNames:
    type: comma_delimited_list
    default: []
~~~

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/637569

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/637569
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=703bf1c050204fea033408f1f07ddf112fb5ea62
Submitter: Zuul
Branch: master

commit 703bf1c050204fea033408f1f07ddf112fb5ea62
Author: Alex Schultz <email address hidden>
Date: Mon Feb 18 08:30:50 2019 -0700

    Add missing RoleParameters and ServiceNames

    RoleParamters and ServiceNames are required parameters for
    PreNetworkConfig

    Change-Id: I0ff266d12a652b6cbe49fcbe87046302c872f56c
    Closes-Bug: #1816450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/638163

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/638164

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638164
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b6ebb07c7ba3f420fd7bc94ded3eb9f9d56201ed
Submitter: Zuul
Branch: stable/queens

commit b6ebb07c7ba3f420fd7bc94ded3eb9f9d56201ed
Author: Alex Schultz <email address hidden>
Date: Mon Feb 18 08:30:50 2019 -0700

    Add missing RoleParameters and ServiceNames

    RoleParamters and ServiceNames are required parameters for
    PreNetworkConfig

    Change-Id: I0ff266d12a652b6cbe49fcbe87046302c872f56c
    Closes-Bug: #1816450
    (cherry picked from commit 703bf1c050204fea033408f1f07ddf112fb5ea62)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638163
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0a39efefe61d8866efff27f7cb32e1fed7ec17cd
Submitter: Zuul
Branch: stable/rocky

commit 0a39efefe61d8866efff27f7cb32e1fed7ec17cd
Author: Alex Schultz <email address hidden>
Date: Mon Feb 18 08:30:50 2019 -0700

    Add missing RoleParameters and ServiceNames

    RoleParamters and ServiceNames are required parameters for
    PreNetworkConfig

    Change-Id: I0ff266d12a652b6cbe49fcbe87046302c872f56c
    Closes-Bug: #1816450
    (cherry picked from commit 703bf1c050204fea033408f1f07ddf112fb5ea62)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.