From a8eff3d96b5242d6d14332118c2a2dfa21c31161 Mon Sep 17 00:00:00 2001 From: "a. bellenir" Date: Thu, 14 Feb 2019 16:16:53 -0500 Subject: [PATCH] lp 1815950 : hide fields if the *.show setting is set to false when org unit settings like au.prefix.show are set to true, the field is made visible when the user shows "Suggested" or "Required" fields setting au.prefix.show to false had no effect. this change will hide the field entirely (even from "All Fields") if the relevant '.show' setting is explicitly false (not just undefined) by setting a negative value in field_visibility[field_key] Signed-off-by: a. bellenir --- Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js index e33933acb3..5f3889f9bc 100644 --- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js +++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js @@ -1518,6 +1518,10 @@ function($scope , $routeParams , $q , $uibModal , $window , egCore , } else if ($scope.org_settings[sug_set]) { field_visibility[field_key] = 1; + + } else if ($scope.org_settings[sho_set] === false){ + // hide the field if the 'show' setting is explicitly false (not undefined) + field_visibility[field_key] = -1; } } -- 2.20.1