build-test-package does not fail on partial builds
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Won't Fix
|
High
|
Unassigned |
Bug Description
In case we have a review with multiple changes and one of them fails at build it's RPM by build-test-package non of the changes is applied and the job continues, let's just make the job fail if one of the changes is not built.
One specific stuff have being using a Depends-On at github.com we are not prepared for it we ned to merge https:/
Example of review with githu.com depends-on, and job passing without applying THT changes:
https:/
The issue is that repo_buildt.skipped is the last package is cannot be built so it skip all of them.
repo_built definition
http://
The use of it
http://
Also depending on the order of the changes the result is diffent since we are reusing the same register
Changed in tripleo: | |
status: | Triaged → In Progress |
Changed in tripleo: | |
milestone: | none → stein-3 |
importance: | High → Critical |
tags: | added: promotion-blocker |
tags: |
added: alert removed: promotion-blocker |
Changed in tripleo: | |
milestone: | stein-3 → stein-rc1 |
Changed in tripleo: | |
milestone: | train-1 → train-2 |
Changed in tripleo: | |
milestone: | train-2 → train-3 |
Changed in tripleo: | |
assignee: | Quique Llorente (quiquell) → nobody |
Changed in tripleo: | |
milestone: | train-3 → ussuri-1 |
Changed in tripleo: | |
milestone: | ussuri-1 → ussuri-2 |
I see in https:/ /logs.rdoprojec t.org/11/ 636511/ 5/openstack- check/tripleo- ci-centos- 7-ovb-3ctlr_ 1comp-featurese t001/93b8ab2/
that tht was built and applied Feb 19 08:31:28 Updated: openstack- tripleo- heat-templates- 10.3.1- 0.2019021908303 4.25c6312. el7.noarch
I'm +1 on being defensive w/ regards to package failing to build and applied. I'd like to see more details