firmware/fwts_server log is not being attached

[Jeff Lane ]

The firmware/fwts_server test runs fwts jobs and creates a log file that is SUPPOSED to be attached.

However, it is not being attached.

For example: https://certification.canonical.com/hardware/201902-26831/submission/138660/

the submission files directory for that submission does not contain the fwts_server log file so I have no idea what the failed tests are.

[Jeff Lane  (bladernr)]

typo :)

[Sylvain Pineau (sylvain-pineau)]

Tested with the last stable release 0.49, it works:

--------------[ Running job 2 / 3. Estimated time left: 0:00:10 ]---------------
--------------------[ Run FWTS Server Cert selected tests. ]--------------------
ID: com.canonical.certification::firmware/fwts_server
Category: com.canonical.plainbox::firmware
... 8< -------------------------------------------------------------------------
Enter sudo password:

Critical Failures: 3
High Failures: 1
Medium Failures: 2
Low Failures: 1
Passed: 31
Skipped Tests: 54
Unavailable Tests: 1
WARNINGS: 1
Aborted Tests: 1
[sudo] password for sylvain: ------------------------------------------------------------------------- >8 ---
Outcome: job failed
--------------[ Running job 3 / 3. Estimated time left: 0:00:00 ]---------------
---------------[ Attach FWTS Server Cert test log to submission ]---------------
ID: com.canonical.certification::firmware/fwts_server_results.log.gz
Category: com.canonical.plainbox::firmware
... 8< -------------------------------------------------------------------------
Outcome: job passed
Finalizing session that hasn't been submitted anywhere: checkbox-run-2019-10-07T07.34.01
==================================[ Results ]===================================
Saving results to /tmp/toto.tar.xz
sylvain@sylvain-ThinkPad-T480s:~$ xdg-open /tmp/toto.tar.xz
sylvain@sylvain-ThinkPad-T480s:~$ tar tvf /tmp/toto.tar.xz
-rw-r--r-- 0/0 833907 2019-10-07 09:36 submission.html
-rw-r--r-- 0/0 142443 2019-10-07 09:36 submission.json
-rw-r--r-- 0/0 521 2019-10-07 09:36 submission.junit
-rw-r--r-- 0/0 98178 2019-10-07 09:36 submission.xlsx
-rw-r--r-- sylvain/sylvain 152 2019-10-07 09:36 test_output/com.canonical.certification__firmware_fwts_server
-rw-r--r-- sylvain/sylvain 29 2019-10-07 09:36 test_output/com.canonical.certification__firmware_fwts_server.stderr
-rw-r--r-- sylvain/sylvain 32571 2019-10-07 09:36 attachment_files/com.canonical.certification__firmware_fwts_server_results.log.gz
-rw-r--r-- sylvain/sylvain 130881 2019-10-07 09:34 test_output/com.canonical.certification__executable
-rw-r--r-- sylvain/sylvain 56 2019-10-07 09:34 test_output/com.canonical.certification__executable.stderr
sylvain@sylvain-ThinkPad-T480s:~$