snapcraft leaks build-environment across parts

[Olivier Tilloy]

Just came across this while testing the build-environment keyword, here is a simple reproducer:

name: test
version: "1.0"
summary: foo bar
description: foo bar baz

confinement: strict
grade: stable
base: core18

parts:
  first:
    plugin: nil
    build-environment:
      - FOO: bar
  second:
    plugin: nil
    after: [ first ]
    override-build: "echo FOO: $FOO"

I would expect the build-environment for part "second" to be empty, but it looks like the build-environment for part "first" is leaked into other parts that are built afterward:

$ SNAPCRAFT_BUILD_ENVIRONMENT=host snapcraft
Pulling first
'second' has dependencies that need to be staged: first
Skipping pull first (already ran)
Building first
Staging first
Pulling second
Skipping build first (already ran)
Building second
FOO: bar
Skipping stage first (already ran)
Staging second
Priming first
Priming second
Snapping 'test' |
Snapped test_1.0_amd64.snap

[Sergio Schvezov (sergiusens)]

This should probably be all that is needed http://paste.ubuntu.com/p/ZFYf2hxjfM/

[Sergio Schvezov (sergiusens)]

https://github.com/snapcore/snapcraft/pull/2472