ObjectVersionChecker should not be logging at INFO level

Bug #1815223 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.versionedobjects
Fix Released
Low
Matt Riedemann

Bug Description

This was found while debugging a nova bug that shows up intermittently in py35 unit test runs:

https://bugs.launchpad.net/nova/+bug/1813147/comments/25

The ObjectVersionChecker fixture in oslo.versionedobjects is logging at INFO level which can be a lot of output in certain nova tests and blow up the subunit parser with the output stream capture.

There doesn't seem to be a great reason to need to log at INFO level in a test fixture, so we should probably drop that to DEBUG which most tests shouldn't be capturing at that level unless configured to do so, e.g. the OS_DEBUG environment variable found in oslotest.

Tags: testing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to oslo.versionedobjects (master)

Fix proposed to branch: master
Review: https://review.openstack.org/635894

Changed in oslo.versionedobjects:
assignee: nobody → Matt Riedemann (mriedem)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to oslo.versionedobjects (master)

Reviewed: https://review.openstack.org/635894
Committed: https://git.openstack.org/cgit/openstack/oslo.versionedobjects/commit/?id=1fbd1b557a43cb74c5d6b07e1d03c4417811c96b
Submitter: Zuul
Branch: master

commit 1fbd1b557a43cb74c5d6b07e1d03c4417811c96b
Author: Matt Riedemann <email address hidden>
Date: Fri Feb 8 12:32:53 2019 -0500

    Lower ObjectVersionChecker logging to DEBUG level

    The ObjectVersionChecker fixture is logging object
    comparison at INFO which in some tests can blow up
    the subunit output stream capture parser (see nova
    bug 1813147). This change drops the logging level
    to DEBUG which can be enabled using the OS_DEBUG
    environment variable found in oslotest.

    Change-Id: If20663ecad19f18f22172ae489206b42489fd9f6
    Closes-Bug: #1815223

Changed in oslo.versionedobjects:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/oslo.versionedobjects 1.35.0

This issue was fixed in the openstack/oslo.versionedobjects 1.35.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.