Duplicated code between mistral.utils and mistral_lib.utils

[Kevin Pouget]

Is there any reason to keep functions `cut`, `cut_string`, `cut_list` and `cut_dict`, present in mistral_lib.utils, duplicated in mistral.utils ?

Could be convenient to use the mistral_lib ones only, to be able to update/fix utils functions at one place.

[Renat Akhmerov (rakhmerov)]

You're correct. They are not needed in mistral repo anymore. It's just a left over from the refactoring around mistral-lib. I'm in favour of moving all utils actually into mistral-lib.

[Renat Akhmerov (rakhmerov)]

I assigned it to T-2 but if you can't take care of that please either move it to a later time or we can reassign it to someone else.

[Kevin Pouget (kpouget)]

> I'm in favour of moving all utils actually into mistral-lib.

Do you meen moving all functions in mistral/utils/__init__.py in mitral-lib/utils/__init.__.py ?

I actually have a patch that remove functions `cut`, `cut_string`, `cut_list` and `cut_dict` from mistral/utils/__init__.py, and replace imports of them to use the mistral-lib ones.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/675086

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/675086
Committed: https://git.openstack.org/cgit/openstack/mistral-lib/commit/?id=070080bd1bc4c4742f6a98370b7ce1616084eded
Submitter: Zuul
Branch: master

commit 070080bd1bc4c4742f6a98370b7ce1616084eded
Author: ali <email address hidden>
Date: Wed Aug 7 10:28:46 2019 +0000

    moved generic util functions from mistral to mistral-lib

    Change-Id: I780c270e4b1a184d7d4dcc580d23697ba75edab1
    Closes-bug: #1815183

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/676373

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral-lib 1.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/676373
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=7e7f1cb92b34b62b235c52e45fea187e466f40cb
Submitter: Zuul
Branch: master

commit 7e7f1cb92b34b62b235c52e45fea187e466f40cb
Author: ali <email address hidden>
Date: Wed Aug 14 09:03:30 2019 +0000

    moved generic util functions from mistral to mistral-lib

    Depends-On: I780c270e4b1a184d7d4dcc580d23697ba75edab1
    Closes-bug: #1815183
    Change-Id: I5a1d402baa3f69c37f9347c8b3d02a83b8f60423

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 9.0.0.0b1 development milestone.