virsh power driver shouldn't allow passing in extra parameters
Bug #1815136 reported by
Newell Jensen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Newell Jensen |
Bug Description
Currently, with the Virsh power driver a user can add extra parameters to the user provided URL such as the 'command' parameter which would allow a user to execute any script/command on the rack controller as the maas user.
Virsh power parameters should most likely be just the IP address, username, and password (optional) and MAAS would construct the appropriate URL from this.
Related branches
~newell-jensen/maas:lp1815136
Merged
into
maas:master
- Alberto Donato (community): Approve
- MAAS Lander: Approve
-
Diff: 68 lines (+23/-6)2 files modifiedsrc/provisioningserver/drivers/pod/tests/test_virsh.py (+12/-3)
src/provisioningserver/drivers/pod/virsh.py (+11/-3)
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.6.0 → 2.6.0alpha1 |
milestone: | 2.6.0alpha1 → 2.6.0alpha2 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi there,
I am aware of this change and have been trying to work around it.
whenever I do not assign a hostname to VMWare, running this command: <vmware_ IP> list --all
virsh -c esx://root@
will output:
error: failed to connect to the hypervisor
error: internal error: curl_easy_perform() returned an error: SSL peer certificate or SSH remote key was not OK (51) : SSL: certificate subject name (<vmware_IP>) does not match target host name '<vmware_IP>'
I then generated SSL certs and exchanged them between the MAAS servers and VMWare until I am able to list the VMs using: <vmware_ hostname> list --all
virsh -c esx://root@
Now the problem is that when I try to add them through MAAS, using: esx://root@ <vmware_ hostname> ,
MAAS does not read the hostname and translate them properly, this is the error message:
[info] BMC could not save extracted IP address '<vmware_ hostname> ': 'failed to detect a valid IP address from '<vmware_ hostname> ''
Since this has just been recently, there's not alot of resources for this fix. I hope someone here can help!