setupinfo.py flags() does not run on Windows

[Koen]

on line 139 in setupinfo.py (function flags()), close_fds is set to True:
        p = subprocess.Popen(cmd, shell=True, close_fds=True,
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE)
However, on Windows, close_fds is not available, so I've set it to False to make it work for me. Probably should be changed to a condition check.
        p = subprocess.Popen(cmd, shell=True, close_fds=False,
                             stdout=subprocess.PIPE, stderr=subprocess.PIPE)

[Koen (ksande)]

This is using Python 2.5.1 on Windows XP (32-bit).

[scoder (scoder)]

Hmm, I didn't add this myself - no idea why it should be needed. Guess I'll just remove it...