When using the option rbd-pool-name=cinder (for migration), the cinder-ceph charm still tries to create the cinder-ceph pool in Ceph

[Xav Paice]

When I deploy cinder-ceph using

juju deploy --config rbd-pool-name=cinder cs:~openstack-charmers-next/cinder-ceph

As per the documentation at https://docs.openstack.org/project-deploy-guide/charm-deployment-guide/latest/app-upgrade-openstack.html#cinder-ceph-topology-change-upgrading-from-newton-to-ocata, I expect the charm to use the existing Ceph pool 'cinder'. However, although that is in the config file for cinder.conf, the hooks still try to create the pool.

Log entry:

juju-log osd:258: Command '['ceph', '--id', 'admin', 'osd', 'pool', 'create', 'cinder-ceph', '2048']'

See https://github.com/openstack/charm-cinder-ceph/blob/master/hooks/cinder_hooks.py#L107 - service_name() shouldln't be used here if we have set rbd-pool-name.

service = service_name()
...
rq.add_op_create_pool(name=service, ...

[Xav Paice (xavpaice)]

Subscribing ~field-high as this affected a production customer, prevented relation hooks from completing and although we've worked around things for now, it'll hit other production customers in the very near future.

[Chris MacNaughton (chris.macnaughton)]

There is a fix proposed at https://review.openstack.org/#/c/634881/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/634881
Committed: https://git.openstack.org/cgit/openstack/charm-cinder-ceph/commit/?id=511f2f0a199b6b6fca528518b5f624d29fb4a7de
Submitter: Zuul
Branch: master

commit 511f2f0a199b6b6fca528518b5f624d29fb4a7de
Author: Chris MacNaughton <email address hidden>
Date: Tue Feb 5 09:30:58 2019 +0100

    Ensure we use the correct pool name

    Change-Id: Ieaee887b03ac4e9ae880ff27e0660f9269c16c2e
    Closes-Bug: #1814603