Handle All Eagle pad shapes

[Seth Hillbrand]

We should finish implementing the Eagle pad shapes. Octagons can be mapped to a custom pad shape as can offset pads. Right now neither of these is handled well.

Application: kicad
Version: (6.0.0-rc1-dev-1682-g8ca76177c0-dirty), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2q zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-8-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Rene Poeschl (poeschlr)]

Custom pad shapes do not support thermals right now [1]. Mapping octagon to custom is at best a hotfix. A full support for them can only happen with the chamfered pads that might be added to version 6 [2]. (Or if custom pads support thermals)

[1] https://bugs.launchpad.net/kicad/+bug/1732720
[2] https://bugs.launchpad.net/kicad/+bug/1777516

[KiCad Janitor (kicad-janitor)]

Fixed in revision 44e111b37e372307000b5682b5e3dd1553623d11
https://git.launchpad.net/kicad/patch/?id=44e111b37e372307000b5682b5e3dd1553623d11

[Wayne Stambaugh (stambaughw)]

If this affects the 5.1 branch, it should be cherry-picked.

[Seth Hillbrand (sethh)]

It relies on the new pad shapes, so it'll need to remain a 6.0-only feature.