soft_delete is wrong
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
High
|
Gorka Eguileor | ||
oslo.db |
Fix Released
|
Medium
|
Matt Riedemann |
Bug Description
as seen in https:/
sqlalchemy.
this is because the "evaluate" synchronization strategy would like to search for objects and update them based on the UPDATE criteria passed, however the columns given, literal_
the correct implementation should be:
class Query(sqlalchem
"""Subclass of sqlalchemy.query with soft_delete() method."""
def soft_delete(self, synchronize_
entity = self.column_
return self.update(
Changed in oslo.db: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in cinder: | |
status: | New → In Progress |
importance: | Undecided → High |
milestone: | none → wallaby-rc1 |
Thanks Mike, I can confirm that your patch fixes the warning when I patched it into my nova py35 tox environment and re-ran tests where I have the SAWarning setup with a warnings filter to be treated as an error and the test, which was failing before, is passing now.