Mutter upsteam bug: cannot overwrite workspaces layout

[Dmitry Lapshin]

Running up-to-date Ubuntu Cosmic. Since I am running a version with manually applied patched from below, I couldn't use the ubuntu-bug helper.

Bug: When using GNOME extension “Workspace grid” that arranges workspaces in a grid, one can find that horizontal switch animation is replaced with a vertical one. This is caused by a bug in mutter itself, it's acknowledged and fixed in upsteam. Applying the patch for the current version in Ubuntu solves the issue as well.

GIFs of the issue could be found here: https://medium.com/@hkdb/patch-gnome-3-30-for-workspace-grid-1ee8b1dd92f9.

Upstream bug: https://gitlab.gnome.org/GNOME/mutter/issues/270.
Upsteam fix: https://gitlab.gnome.org/rmyorston/mutter/commit/97a3a9b24b36111155003467d5fac6bb1ec1c60e (merged into master 3 months ago).

The patch to fix is, literally, adding 1 meaningful line:

From 86a719cc78149b7db189ff7e5d1f16418d257e9e Mon Sep 17 00:00:00 2001
From: Ron Yorston <email address hidden>
Date: Tue, 2 Oct 2018 12:47:05 +0100
Subject: [PATCH] Allow workspace layout to be overridden

meta_workspace_manager_override_workspace_layout is implemented by
calling meta_workspace_manager_update_workspace_layout which
respects the workspace_layout_overridden flag. After the first call
to meta_workspace_manager_override_workspace_layout all subsequent
calls fail silently.

Reset workspace_layout_overridden to FALSE before calling
meta_workspace_manager_update_workspace_layout.

Signed-off-by: Ron Yorston <email address hidden>
---
 src/core/meta-workspace-manager.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/core/meta-workspace-manager.c b/src/core/meta-workspace-manager.c
index 2670f4938..abc819db0 100644
--- a/src/core/meta-workspace-manager.c
+++ b/src/core/meta-workspace-manager.c
@@ -496,6 +496,8 @@ meta_workspace_manager_override_workspace_layout (MetaWorkspaceManager *workspac
                                                   int n_rows,
                                                   int n_columns)
 {
+ workspace_manager->workspace_layout_overridden = FALSE;
+
   meta_workspace_manager_update_workspace_layout (workspace_manager,
                                                   starting_corner,
                                                   vertical_layout,
--
2.17.1

Hopefully this one is fast to test and apply ;)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Dmitry Lapshin (lapshin-dv)]

Patch as a file

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "0001-Allow-workspace-layout-to-be-overridden.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Marco Trevisan (Treviño) (3v1n0)]

Fixed in mutter 3.31.90-2~fakesync

[Dmitry Lapshin (lapshin-dv)]

Huh. So, when will the fixed version land? For now, I rebuild published version with the patch above.

[Mike Hicks (hick0088)]

Can this be incorporated into the Ubuntu 18.04 version? I manually patched 3.30.2-1~ubuntu18.10.3, but was overwritten by an update to 3.30.2-1~ubuntu18.10.4.

[Mike Hicks (hick0088)]

Correction, I am running Ubuntu 18.10, not 18.04.