python-manilaclient

get_base_url is returning an incomplete value

Bug #1814094 reported by Victoria Martinez de la Cruz on 2019-01-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	python-manilaclient	Fix Released	Medium	Victoria Martinez de la Cruz	python-manilaclient stein-3

Bug Description

get_base_url method makes assumptions on how the base URL should look like and trims it up to the host IP. This breaks the client when the server is deployed differently. We need to fix the way we parse the base url to get the correct path.

Tags:

Victoria Martinez de la Cruz (vkmc) on 2019-01-31

Changed in python-manilaclient:
assignee:	nobody → Victoria Martinez de la Cruz (vkmc)
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-01-31: Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/634345

Changed in python-manilaclient:
status:	Confirmed → In Progress

Tom Barron (tpb) on 2019-02-03

Changed in python-manilaclient:
importance:	Undecided → Medium
milestone:	none → stein-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-06: Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/634345
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=cb1ac1ad910efcd716c2e785699c44179fb1a8cf
Submitter: Zuul
Branch: master

commit cb1ac1ad910efcd716c2e785699c44179fb1a8cf
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Thu Jan 31 14:00:32 2019 +0000

Fix get_base_url

    get_base_url method makes assumptions on how the
    base URL should look like and trims it up to the
    host IP. This change modifies how the base endpoint
    is processed so we get the correct values.

Change-Id: Ie01b02f2e731e25fd4032436d3fa106da03af242
Closes-Bug: #1814094

Changed in python-manilaclient:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-03-07: Fix included in openstack/python-manilaclient 1.27.0

This issue was fixed in the openstack/python-manilaclient 1.27.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-15: Fix proposed to python-manilaclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/652779

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-16: Fix merged to python-manilaclient (stable/rocky)

Reviewed: https://review.openstack.org/652779
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=816bfc82e7a1835cdbfccf0e023beb4c11eb2a30
Submitter: Zuul
Branch: stable/rocky

commit 816bfc82e7a1835cdbfccf0e023beb4c11eb2a30
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Thu Jan 31 14:00:32 2019 +0000

Fix get_base_url

    Change-Id: Ie01b02f2e731e25fd4032436d3fa106da03af242
    Closes-Bug: #1814094
    (cherry picked from commit cb1ac1ad910efcd716c2e785699c44179fb1a8cf)

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-16: Fix proposed to python-manilaclient (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/652973

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-17: Fix included in openstack/python-manilaclient 1.24.2

This issue was fixed in the openstack/python-manilaclient 1.24.2 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-17: Fix merged to python-manilaclient (stable/queens)

Reviewed: https://review.openstack.org/652973
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=f9384b1005f780c25501232c82686d668608d1f0
Submitter: Zuul
Branch: stable/queens

commit f9384b1005f780c25501232c82686d668608d1f0
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Thu Jan 31 14:00:32 2019 +0000

Fix get_base_url

    Change-Id: Ie01b02f2e731e25fd4032436d3fa106da03af242
    Closes-Bug: #1814094
    (cherry picked from commit cb1ac1ad910efcd716c2e785699c44179fb1a8cf)
    (cherry picked from commit 816bfc82e7a1835cdbfccf0e023beb4c11eb2a30)