we should reduce the frame buffer size in NewWebsocket

Bug #1813868 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
John A Meinel
2.5
Fix Released
High
John A Meinel

Bug Description

For compatibility with clients that didn't support framing, when we introduced the new gorilla websockets, we used 64kB buffers. However, that is now a significant source of memory overhead.

Since gorilla supports message frames, and we no longer need to worry about 2.1 agents/clients against a new controller, we should be able to drop the buffers back to their default 4096 bytes.

We need to do cross-version testing with reasonably large messages to convince ourselves that the frames are working correctly, but that should reduce one of our primary sources of memory consumption.

Revision history for this message
John A Meinel (jameinel) wrote :

https://github.com/juju/juju/pull/9701 is a patch against 2.5. We may go for 2.5.1 or we may delay for 2.5.2

Changed in juju:
status: Triaged → In Progress
assignee: nobody → John A Meinel (jameinel)
milestone: 2.5.2 → 2.6-beta1
Tim Penhey (thumper)
Changed in juju:
status: In Progress → Fix Committed
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.