Using "Add layer alignment target" with "Place auxillary axis" creates artifacts

[Aleksandr Sh]

If you click on icons of these tools, layer alignment targets get created. But they are weird and removed one by one when pressing ESC. If you switch to select tool, you can kind of place some of them.
See the video.

Application: kicad
Version: (6.0.0-rc1-dev-1606-g4cd41e394), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

Was this with on of the modern canvases or the legacy canvas? I cannot duplicate this behavior on 5.1.0-rc1-28-g605d0ab3c on Linux using either modern canvas.

[Aleksandr Sh (dsa-t)]

With modern canvas, can still be reproduced.

Application: kicad
Version: (5.1.0-rc1-27-g03e787ef2), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Aleksandr Sh (dsa-t)]

Does not reproduce in Legacy Toolset.

[Wayne Stambaugh (stambaughw)]

It appears that there is a tool state issue at play here.

[Jeff Young (jeyjey)]

TOOL_MANAGER's event dispatch logic is having trouble when the activating tool and the deactivating tool are both states in the same TOOL_INTERACTIVE.

[Jeff Young (jeyjey)]

Two ACTIONs by the same TOOL_INTERACTIVE turned out to be a red herring. It was just some missing AF_ACTIVATE flags on the ACTIONs in question.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 815602d1af0f3d4381b0795cbe9bec55d38afc51
https://git.launchpad.net/kicad/patch/?id=815602d1af0f3d4381b0795cbe9bec55d38afc51