search catalog flips between UIs

[James Fournie]

Hi! I'm testing master @ 32d52c

When I am on an eg2 interface such as Booking Admin or Acq Admin and then click on "Search -> Search the Catalog" I get the Angular staff catalog.

When I am on a regular eg interface and click "Search -> Search the Catalog" I get the regular catalog.

It looks like the Angular staff catalog isn't finished or at least is supposed to be merged in LP 1806087

It looks like this code got merged in @ 6c706f454b2b9

I would suggest that it is not very user friendly to have the same button do different things depending on which interface you click on it from.

[Bill Erickson (berick)]

Confirmed. This is an oversight. The menu entry for "Cataloging => Search The Catalog" is correct, so that entry could be copied into place under the main "Search" menu.

[Mike Rylander (mrylander)]

I asked in IRC, but more broadly, are there any objections to me just fixing this and pushing it to master now? I'd prefer to avoid the time of a branch dance... :)

[Jason Boyer (jboyer)]

Sounds good to me.

[Jason Stephenson (jstephenson)]

OK by me.

[Mike Rylander (mrylander)]

Interestingly, the search link seems to be correct in current master (fixed back in November of 2018 in 7075905d588919bce7e6a520b3a061e142e16e19). I'm correcting the splash page link here, and that's it.

[Terran McCanna (tmccanna)]

Noting that this fix was released back in 2019, but the status was not updated at the time.