[queens][ffu] For NFV deployments, remove newton's first-boot script and use PreNetworkConfig

[Saravanan KR]

In newton NFV deployments, the kernel args are applied using the
userdata scripts (first-boot). In queens NFV deployments, the userdata
scripts are rebooted, instead PreNetworkConfig resource is added
to allow kernel args configuration and reboot. During FFU, instead
of using the first-boot, migrating to PreNetworkConfig resource,
requires a check to ensure that a additional reboot is not applied.

After queens fresh deployment and subsequent updates, the reboot is
avoided by removing UPDATE in the deployment_actions of PreNetworkConfig.
During FFU, addition of PreNetworkConfig will result in the CREATE
action, as it is created first time (not available in newton), this
additional check is required to avoid reboot.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/636309

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/636310

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/636311

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636309
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8aa46b6c8d1a861efefa43b6d6e5267c155744f5
Submitter: Zuul
Branch: stable/queens

commit 8aa46b6c8d1a861efefa43b6d6e5267c155744f5
Author: Saravanan KR <email address hidden>
Date: Wed Apr 11 18:38:37 2018 +0530

    NFV: Support for config-download to deploy node with kernel args

    For NFV deployments, specific kernel args should be applied and
    the nodes should be restarted before running the NetworkDeployment.
    It is supported in the heat deployment via PreNetworkConfig. In the
    config-download mechanism, ansible steps need to be improved
    to handle the reboot and wait for the node.
    Related-Bug: #1813610

    Change-Id: I43b383ad0e04b8be6c321f8c5b05e628b2520141
    (cherry picked from commit a3e4a9063612a617105e318e422d90706e4ed43e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636310
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=967542fcb18363b85fdd6cf5cde5844c1321b693
Submitter: Zuul
Branch: stable/queens

commit 967542fcb18363b85fdd6cf5cde5844c1321b693
Author: Saravanan KR <email address hidden>
Date: Mon Jan 28 12:27:11 2019 +0530

    [stable/queens] Disable default config-download method for PreNetworkConfig

    While backporting config-download support for NFV from rocky, the
    default option is to use config-download. But in queens the default
    option is to use heat with an opt-in config-download support. Disable
    config-download based resources and provide an option to enable via
    environment file.
    Related-Bug: #1813610

    Change-Id: I9c0bf922555f9c3cd8c11e42e2ee525490754845

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/636311
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c05aa892eb7119f590e0e0488c0fb6a977d34e43
Submitter: Zuul
Branch: stable/queens

commit c05aa892eb7119f590e0e0488c0fb6a977d34e43
Author: Saravanan KR <email address hidden>
Date: Mon Jan 28 19:41:49 2019 +0530

    [stable/queens] Add a check for kernels args update to avoid unnecessary reboot

    In newton NFV deployments, the kernel args are applied using the
    userdata scripts (first-boot). In queens NFV deployments, the userdata
    scripts are rebooted, instead PreNetworkConfig resource is added
    to allow kernel args configuration and reboot. During FFU, instead
    of using the first-boot, migrating to PreNetworkConfig resource,
    requires a check to ensure that a additional reboot is not applied.

    After queens fresh deployment and subsequent updates, the reboot is
    avoided by removing UPDATE in the deployment_actions of PreNetworkConfig.
    During FFU, addition of PreNetworkConfig will result in the CREATE
    action, as it is created first time (not available in newton), this
    additional check is required to avoid reboot.
    Closes-Bug: #1813610

    Change-Id: I89c7a686c301861defe23963f6aa8c36c43c4bb5

[Saravanan KR (skramaja)]

Its stable/queens only changes. All the required changes are merged.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.4.0 release.