tripleo-upgrade using wrong overcloud-ssh-user

[Jose Luis Franco]

CI job tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades is failing during the overcloud upgrade prepare command when configuring the ssh access:

2019-01-23 19:11:40 | Using ssh user tripleo-admin for initial connection.
2019-01-23 19:11:40 | Using ssh key at /home/zuul/.ssh/id_rsa for initial connection.
2019-01-23 19:11:40 | Inserting TripleO short term key for 192.168.24.3
2019-01-23 19:11:40 | Removing short term keys locally
2019-01-23 19:11:40 | 2019-01-23 19:11:40.518 206493 ERROR tripleoclient.v1.overcloud_upgrade.MajorUpgradePrepare [-] Exception occured while running the command: CalledProcessError: Command '['ssh', '-o', 'ConnectionAttempts=6', '-o', 'ConnectTimeout=30', '-o', 'StrictHostKeyChecking=no', '-o', 'PasswordAuthentication=no', '-o', 'UserKnownHostsFile=/dev/null', '-o', 'StrictHostKeyChecking=no', '-i', '/home/zuul/.ssh/id_rsa', '-l', u'tripleo-admin', u'192.168.24.3', "echo -e '\nssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDeaTsoU5ETJ27Koqb0GKGjsEHllAN2F68xP6trBKNn7ksK2tM6b5pJH/dZa+UgkCdpHjF2mu6jipNFWvcEG1Uql0Z38k6LLGAw6VF7dx5wHA+8aC9a0lf8jsNKKVohrU/a4PTvOViHqVb4TGSAqNeLj0yCjV6IBMFHRXLKlyb5ytjM7VC0TQ7AxyRbnBwM0NfFUVXyLctNGI7iINoBTRFnmx8vHhngx2vo/8o/yIi58yfkpPn0k2FAMt1Nx49GsPV8WtMBjAZ7SMWOrRupeOWZ+AmGE4k0rTKM9VJdbOKvPDofPVotz1mEVgLPuEiDamifHWblatbVTehy921shjW07nfzfFbWzotlfINEap7NbcB8ZxDBhW8ZcZC4V1Ip8KQQEPjLVrgPR+YWYnzli28VMeLpuan2fLFsd/b2lC3ncbOD7XBl35dOxEtRD/uTbFcuapvY8kX3D5SHjutUo1kPAR/wblBjF4r6VdmOthYM6kEemjSod7mF+PVWaziSKkRVsO6gasjkQnw8G916hv/RH4rs+pVzXI8yCwfh8EewhFi5pPg947al6qLG1izVwcr3WJ2Nc0kTwDDtdywzs6UWMDn/h59HAUjuBQx4mJZCFpDa8kkqbTOZiVc0S+tH6scpVrNziil5ANnlMS8kTn/DNulprQzAP3JzHQeLcXmY7w== TripleO split stack short term key\n' >> $HOME/.ssh/authorized_keys"]' returned non-zero exit status 255

Log: http://logs.openstack.org/25/607525/5/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/8daa6ad/logs/undercloud/home/zuul/overcloud_upgrade_prepare.log.txt.gz#_2019-01-23_19_11_40

The reason is the user being passed to the upgrade command:

echo "Running major upgrade prepare step"
openstack overcloud upgrade prepare --stack overcloud \
    --templates /usr/share/openstack-tripleo-heat-templates \
    --overcloud-ssh-user tripleo-admin \

http://logs.openstack.org/25/607525/5/check/tripleo-ci-centos-7-scenario000-multinode-oooq-container-upgrades/8daa6ad/logs/undercloud/home/zuul/overcloud_upgrade_prepare.sh.txt.gz

In comparison with the one used during overcloud deployment which uses zuul user:

openstack overcloud deploy \
--override-ansible-cfg /home/zuul/custom_ansible.cfg \
    --templates /usr/share/openstack-tripleo-heat-templates \
    --libvirt-type qemu \
--timeout 90 \
-e /home/zuul/cloud-names.yaml \
-e /home/zuul/hostnamemap.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/deployed-server-environment.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/deployed-server-bootstrap-environment-centos.yaml \
--overcloud-ssh-user zuul \

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/633486

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/633486
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=22faab5b303bf19835bb69332ee484ffbbc10272
Submitter: Zuul
Branch: master

commit 22faab5b303bf19835bb69332ee484ffbbc10272
Author: Jose Luis Franco Arza <email address hidden>
Date: Mon Jan 28 12:58:06 2019 +0100

    Set overcloud_ssh_user to zuul in upgrades jobs.

    Currently, we are using zuul user as overcloud_ssh_user during overcloud
    deployment. While for upgrades, we are still passing tripleo-admin. This
    is causing the upgrade prepare command to fail.

    Change-Id: If4bd02dad8d69ba4c818ba8d800423bcc8ecfea4
    Closes-Bug: #1813564

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart 2.1.1 release.