qemu/target/arm/translate-a64.c:2039: bad test ?

[dcb]

qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction always evaluates to true: op3 != 2 || op3 != 3.

Source code is

       if (op3 != 2 || op3 != 3) {

Maybe better code

       if (op3 != 2 && op3 != 3) {

[dcb (dcb314)]

Maybe using gcc flag -Wlogical-op might help find bugs like this in future.

[Richard Henderson (rth)]

There is a patch on list for this:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html

Using the flag is a good idea.

[Richard Henderson (rth)]

The patch is now in master.