trace-root.h is not regerenerated after re-configure

[Christophe Lyon]

Hi,

I've just realized that after I reconfigured my qemu with
../configure --target-list=arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user --enable-trace-backends=simple

$ make
did rebuild some stuff for the 'simple' trace, but it did not update trace-root.h until after I
$ make clean

I took me while to understand why I didn't get the traces I wanted (my trace-root.h still thought it was configured for the default 'log').

I didn't check how easy it is to fix this in the build system.

Thanks

[Stefan Hajnoczi (stefanha)]

On Fri, Jan 25, 2019 at 02:03:39PM -0000, Christophe Lyon wrote:
> I've just realized that after I reconfigured my qemu with
> ../configure --target-list=arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user --enable-trace-backends=simple
>
> $ make
> did rebuild some stuff for the 'simple' trace, but it did not update trace-root.h until after I
> $ make clean
>
>
> I took me while to understand why I didn't get the traces I wanted (my trace-root.h still thought it was configured for the default 'log').
>
> I didn't check how easy it is to fix this in the build system.

Thank you for reporting this. I have sent a patch to fix the makefile.

Stefan

[Christophe Lyon (christophe-lyon)]

On Tue, 29 Jan 2019 at 03:55, Stefan Hajnoczi <email address hidden> wrote:
>
> On Fri, Jan 25, 2019 at 02:03:39PM -0000, Christophe Lyon wrote:
> > I've just realized that after I reconfigured my qemu with
> > ../configure --target-list=arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user --enable-trace-backends=simple
> >
> > $ make
> > did rebuild some stuff for the 'simple' trace, but it did not update trace-root.h until after I
> > $ make clean
> >
> >
> > I took me while to understand why I didn't get the traces I wanted (my trace-root.h still thought it was configured for the default 'log').
> >
> > I didn't check how easy it is to fix this in the build system.
>
> Thank you for reporting this. I have sent a patch to fix the makefile.
>

Thanks for the quick patch.

> Stefan

[Peter Maydell (pmaydell)]

This was fixed by commit 57b7bdf426445d83561, which will be in the 4.0 release.