Notify by Email column on Hold Shelf not populating

[Terran McCanna]

In 3.2.2 and 3.0.2: The 'Notify by Email?' (Yes/No) column can be displayed but does not populate on the Hold Shelf screen.

[John Amundson (jamundson)]

This column is displaying Yes/No on our production server, (3.0.12), but is not populating on our training server, (3.2.2).

[Jennifer Pringle (jpringle-u)]

This column displays but doesn't populate values in the Hold Shelf or View Holds (in the record) in 3.3.4

[Jennifer Pringle (jpringle-u)]

Values (Yes/No) populate on our 3.1.7 test server for both Hold Shelf and View Holds.

[Jason Stephenson (jstephenson)]

This looks to be a more general bug than just this one field. None of the Boolean fields populate values for me on a 3.2 test system. I suspect this is related to the hold fetch speed up code introduced in bug 1712854. The code for that appears in Evergreen 3.2+, but not 3.0 nor 3.1.

I'm looking into it to see if I can come up with a fix. I think it has something to do with the eg-grid setup in t_holds_shelf_list.tt2.

[Jason Stephenson (jstephenson)]

It turns out that the problem was an integer versus string value in egGridFilterValue. The branch below alters the check for Boolean columns to force a comparison on string types. Thanks to Mike Rylander for pointing out the type mismatch in IRC!

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1813088-egvf-bool-coercion

[John Amundson (jamundson)]

Thanks for your work on this patch, Jason.

I have tested this internally, and the column is displaying perfectly. Other Boolean columns are also displaying correctly, such as "Copy Deleted".

Since Jason and I are part of the same organization, I won't add a formal sign off, but this can be considered an informal one from me.

[Chris Sharp (chrissharp123)]

Works for me too. Pushed to 3.3, 3.4, 3.5, and master. Thanks, John and Jason!