upgrade-charm may trigger package update (if uninstalled updates present)

Bug #1812982 reported by James Page
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Cinder Charm
Fix Released
Medium
James Page
OpenStack Nova Compute Charm
Fix Released
Medium
James Page

Bug Description

If pending package updates are present, a charm upgrade may trigger a package upgrade; this is a-typical of openstack charm behaviour and the package list should be filtered based on packages already installed.

Revision history for this message
James Page (james-page) wrote :

As this only impacts a deployment where there are pending stable package updates, marking as medium but still needs a stable fix for consistency across the charms.

Changed in charm-cinder:
status: New → Triaged
importance: Undecided → Medium
Changed in charm-nova-compute:
status: New → Triaged
importance: Undecided → Medium
Changed in charm-cinder:
assignee: nobody → James Page (james-page)
Changed in charm-nova-compute:
assignee: nobody → James Page (james-page)
Changed in charm-cinder:
status: Triaged → In Progress
Changed in charm-nova-compute:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-cinder (master)

Reviewed: https://review.openstack.org/632783
Committed: https://git.openstack.org/cgit/openstack/charm-cinder/commit/?id=a0708709675725ad7a945802c85ee460f1e1d26c
Submitter: Zuul
Branch: master

commit a0708709675725ad7a945802c85ee460f1e1d26c
Author: James Page <email address hidden>
Date: Wed Jan 23 17:05:00 2019 +0000

    upgrade-charm: filter previously installed packages

    The upgrade-charm hook installs any new packages required for the
    new charm version however this needs to be filtered against packages
    that are already installed to ensure that any pending package
    updates are not installed as a side effect of a charm upgrade.

    Change-Id: Ie23b65fd97014134ba6f3d9004f18a4600cd2d5a
    Closes-Bug: 1812982

Changed in charm-cinder:
status: In Progress → Fix Committed
Changed in charm-nova-compute:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-nova-compute (master)

Reviewed: https://review.openstack.org/632784
Committed: https://git.openstack.org/cgit/openstack/charm-nova-compute/commit/?id=e9ecd8284fc1d1fc5c64496de7893d179f8315b5
Submitter: Zuul
Branch: master

commit e9ecd8284fc1d1fc5c64496de7893d179f8315b5
Author: James Page <email address hidden>
Date: Wed Jan 23 17:09:15 2019 +0000

    upgrade-charm: filter previously installed packages

    The upgrade-charm hook installs any new packages required for the
    new charm version however this needs to be filtered against previously
    installed packages to ensure that pending package updates don't get
    applied to the system as a side effect of upgrading the charm.

    Change-Id: I6c490f9af2312dc42f2b56e0b7ce8c802e3aac1d
    Closes-Bug: 1812982

James Page (james-page)
Changed in charm-nova-compute:
milestone: none → 19.04
Changed in charm-cinder:
milestone: none → 19.04
David Ames (thedac)
Changed in charm-nova-compute:
status: Fix Committed → Fix Released
Changed in charm-cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.