glance-registry not running post charm upgrade on queens

[James Page]

glance-registry failed to restart due to a missing paste file after a charm upgrade on queens.

The charm in the code for reinstall is < 'queens' but should be <=

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/632782

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/632782
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=c24e2cf4230550741ab057eb891e9b12d6741b64
Submitter: Zuul
Branch: master

commit c24e2cf4230550741ab057eb891e9b12d6741b64
Author: James Page <email address hidden>
Date: Wed Jan 23 16:59:28 2019 +0000

    upgrade: preserve glance-registry for Queens

    The glance-registry daemon was deprecated at Queens, but was still
    installed for the Queens charm release; ensure that any re-install
    of paste.ini files accomodates this as part of the charm upgrade
    process, resolving issues with glance-registry not running due to
    missing paste configuration files.

    Change-Id: Iaaea4907ce4ef9d1e17b8ef9719e8bb0e0001946
    Closes-Bug: 1812972

[Alok G Singh (alephnull-b)]

This patch did not allow glance-registry on start on bionic-queens. The charm removes glance-registry-paste.ini in reinstall_paste_ini() but this file is required for the service to start.

The config file was regenerated by apt install --reinstall --option=Dpkg::Options::=--force-confmiss glance-registry and the service started normally.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/18.11
Review: https://review.openstack.org/638634

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/638634
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=c71044ca0b36285ad790fec45e0ff9c7d7e0866b
Submitter: Zuul
Branch: stable/18.11

commit c71044ca0b36285ad790fec45e0ff9c7d7e0866b
Author: James Page <email address hidden>
Date: Wed Jan 23 16:59:28 2019 +0000

    upgrade: preserve glance-registry for Queens

    The glance-registry daemon was deprecated at Queens, but was still
    installed for the Queens charm release; ensure that any re-install
    of paste.ini files accomodates this as part of the charm upgrade
    process, resolving issues with glance-registry not running due to
    missing paste configuration files.

    Change-Id: Iaaea4907ce4ef9d1e17b8ef9719e8bb0e0001946
    Closes-Bug: 1812972
    (cherry picked from commit c24e2cf4230550741ab057eb891e9b12d6741b64)

[Xav Paice (xavpaice)]

After updating the charm to the current 18.11 (including the backport above), the glance-registry-paste.ini file is missing entirely, and reinstalling the package doesn't fix it. I wound up manually copying in the file from the package source.

Is there something we can do to ensure that this isn't an ongoing issue?

[Xav Paice (xavpaice)]

I've set this to new, because although the patch adds the package install back in, the upgrading the charm doesn't fix installations that are already broken.

[Edward Hope-Morley (hopem)]

Confirmed, i just upgraded to 19.04 charms for a queens deployment and glance-registry won't start anymore due to missing paste.ini:

May 14 09:39:19 juju-52088b-0-lxd-3 glance-registry[21999]: ERROR: Unable to locate paste config file for glance-registry.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/659029

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.04
Review: https://review.opendev.org/659030

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/659029
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=160e5d2d9f332afe6d6581bed0b590153249fdd2
Submitter: Zuul
Branch: master

commit 160e5d2d9f332afe6d6581bed0b590153249fdd2
Author: Edward Hope-Morley <email address hidden>
Date: Tue May 14 11:28:39 2019 +0100

    Ensure glance-registry-paste.ini exists for <= Q

    Change-Id: I84360db1522b735a20f4141235b111700935fe58
    Closes-Bug: #1812972

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/659030
Committed: https://git.openstack.org/cgit/openstack/charm-glance/commit/?id=efd939a188eb5c8d69fd67726f556f7700a875d5
Submitter: Zuul
Branch: stable/19.04

commit efd939a188eb5c8d69fd67726f556f7700a875d5
Author: Edward Hope-Morley <email address hidden>
Date: Tue May 14 11:28:39 2019 +0100

    Ensure glance-registry-paste.ini exists for <= Q

    Change-Id: I84360db1522b735a20f4141235b111700935fe58
    Closes-Bug: #1812972
    (cherry picked from commit 160e5d2d9f332afe6d6581bed0b590153249fdd2)